Commit 8137ae26 authored by Amir Goldstein's avatar Amir Goldstein Committed by Miklos Szeredi

ovl: fix creds leak in copy up error path

Fixes: 42f269b9 ("ovl: rearrange code in ovl_copy_up_locked()")
Cc: <stable@vger.kernel.org> # v4.11
Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
parent 72d42504
...@@ -343,12 +343,13 @@ static int ovl_copy_up_locked(struct dentry *workdir, struct dentry *upperdir, ...@@ -343,12 +343,13 @@ static int ovl_copy_up_locked(struct dentry *workdir, struct dentry *upperdir,
temp = ovl_do_tmpfile(upperdir, stat->mode); temp = ovl_do_tmpfile(upperdir, stat->mode);
else else
temp = ovl_lookup_temp(workdir, dentry); temp = ovl_lookup_temp(workdir, dentry);
err = PTR_ERR(temp);
if (IS_ERR(temp))
goto out1;
err = 0; err = 0;
if (!tmpfile) if (IS_ERR(temp)) {
err = PTR_ERR(temp);
temp = NULL;
}
if (!err && !tmpfile)
err = ovl_create_real(wdir, temp, &cattr, NULL, true); err = ovl_create_real(wdir, temp, &cattr, NULL, true);
if (new_creds) { if (new_creds) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment