Commit 815fd569 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman

USB: opticon.c: remove dbg() tracing calls

dbg() was used a lot a long time ago to trace code flow.  Now that we have
ftrace, this isn't needed at all, so remove these calls.

CC: Johan Hovold <jhovold@gmail.com>
CC: Rusty Russell <rusty@rustcorp.com.au>
CC: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
CC: Julia Lawall <julia@diku.dk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 69d1d34a
...@@ -70,8 +70,6 @@ static void opticon_read_bulk_callback(struct urb *urb) ...@@ -70,8 +70,6 @@ static void opticon_read_bulk_callback(struct urb *urb)
int data_length; int data_length;
unsigned long flags; unsigned long flags;
dbg("%s - port %d", __func__, port->number);
switch (status) { switch (status) {
case 0: case 0:
/* success */ /* success */
...@@ -179,8 +177,6 @@ static int opticon_open(struct tty_struct *tty, struct usb_serial_port *port) ...@@ -179,8 +177,6 @@ static int opticon_open(struct tty_struct *tty, struct usb_serial_port *port)
unsigned long flags; unsigned long flags;
int result = 0; int result = 0;
dbg("%s - port %d", __func__, port->number);
spin_lock_irqsave(&priv->lock, flags); spin_lock_irqsave(&priv->lock, flags);
priv->throttled = false; priv->throttled = false;
priv->actually_throttled = false; priv->actually_throttled = false;
...@@ -216,8 +212,6 @@ static void opticon_close(struct usb_serial_port *port) ...@@ -216,8 +212,6 @@ static void opticon_close(struct usb_serial_port *port)
{ {
struct opticon_private *priv = usb_get_serial_data(port->serial); struct opticon_private *priv = usb_get_serial_data(port->serial);
dbg("%s - port %d", __func__, port->number);
/* shutdown our urbs */ /* shutdown our urbs */
usb_kill_urb(priv->bulk_read_urb); usb_kill_urb(priv->bulk_read_urb);
} }
...@@ -256,8 +250,6 @@ static int opticon_write(struct tty_struct *tty, struct usb_serial_port *port, ...@@ -256,8 +250,6 @@ static int opticon_write(struct tty_struct *tty, struct usb_serial_port *port,
int status; int status;
struct usb_ctrlrequest *dr; struct usb_ctrlrequest *dr;
dbg("%s - port %d", __func__, port->number);
spin_lock_irqsave(&priv->lock, flags); spin_lock_irqsave(&priv->lock, flags);
if (priv->outstanding_urbs > URB_UPPER_LIMIT) { if (priv->outstanding_urbs > URB_UPPER_LIMIT) {
spin_unlock_irqrestore(&priv->lock, flags); spin_unlock_irqrestore(&priv->lock, flags);
...@@ -338,8 +330,6 @@ static int opticon_write_room(struct tty_struct *tty) ...@@ -338,8 +330,6 @@ static int opticon_write_room(struct tty_struct *tty)
struct opticon_private *priv = usb_get_serial_data(port->serial); struct opticon_private *priv = usb_get_serial_data(port->serial);
unsigned long flags; unsigned long flags;
dbg("%s - port %d", __func__, port->number);
/* /*
* We really can take almost anything the user throws at us * We really can take almost anything the user throws at us
* but let's pick a nice big number to tell the tty * but let's pick a nice big number to tell the tty
...@@ -362,7 +352,6 @@ static void opticon_throttle(struct tty_struct *tty) ...@@ -362,7 +352,6 @@ static void opticon_throttle(struct tty_struct *tty)
struct opticon_private *priv = usb_get_serial_data(port->serial); struct opticon_private *priv = usb_get_serial_data(port->serial);
unsigned long flags; unsigned long flags;
dbg("%s - port %d", __func__, port->number);
spin_lock_irqsave(&priv->lock, flags); spin_lock_irqsave(&priv->lock, flags);
priv->throttled = true; priv->throttled = true;
spin_unlock_irqrestore(&priv->lock, flags); spin_unlock_irqrestore(&priv->lock, flags);
...@@ -376,8 +365,6 @@ static void opticon_unthrottle(struct tty_struct *tty) ...@@ -376,8 +365,6 @@ static void opticon_unthrottle(struct tty_struct *tty)
unsigned long flags; unsigned long flags;
int result, was_throttled; int result, was_throttled;
dbg("%s - port %d", __func__, port->number);
spin_lock_irqsave(&priv->lock, flags); spin_lock_irqsave(&priv->lock, flags);
priv->throttled = false; priv->throttled = false;
was_throttled = priv->actually_throttled; was_throttled = priv->actually_throttled;
...@@ -400,8 +387,6 @@ static int opticon_tiocmget(struct tty_struct *tty) ...@@ -400,8 +387,6 @@ static int opticon_tiocmget(struct tty_struct *tty)
unsigned long flags; unsigned long flags;
int result = 0; int result = 0;
dbg("%s - port %d", __func__, port->number);
spin_lock_irqsave(&priv->lock, flags); spin_lock_irqsave(&priv->lock, flags);
if (priv->rts) if (priv->rts)
result |= TIOCM_RTS; result |= TIOCM_RTS;
...@@ -560,8 +545,6 @@ static void opticon_disconnect(struct usb_serial *serial) ...@@ -560,8 +545,6 @@ static void opticon_disconnect(struct usb_serial *serial)
{ {
struct opticon_private *priv = usb_get_serial_data(serial); struct opticon_private *priv = usb_get_serial_data(serial);
dbg("%s", __func__);
usb_kill_urb(priv->bulk_read_urb); usb_kill_urb(priv->bulk_read_urb);
usb_free_urb(priv->bulk_read_urb); usb_free_urb(priv->bulk_read_urb);
} }
...@@ -570,8 +553,6 @@ static void opticon_release(struct usb_serial *serial) ...@@ -570,8 +553,6 @@ static void opticon_release(struct usb_serial *serial)
{ {
struct opticon_private *priv = usb_get_serial_data(serial); struct opticon_private *priv = usb_get_serial_data(serial);
dbg("%s", __func__);
kfree(priv->bulk_in_buffer); kfree(priv->bulk_in_buffer);
kfree(priv); kfree(priv);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment