Commit 827afdf0 authored by Adrian Bunk's avatar Adrian Bunk Committed by Linus Torvalds

n_hdlc.c: fix check-after-use

The Coverity checker spotted that we'd have already oops'ed if "tty"
was NULL.

Since "tty" can't be NULL when we reach this line of code this patch
removes the NULL check.
Signed-off-by: default avatarAdrian Bunk <bunk@kernel.org>
Acked-by: default avatarAlan Cox <alan@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent cba4fbbf
...@@ -229,7 +229,7 @@ static void n_hdlc_release(struct n_hdlc *n_hdlc) ...@@ -229,7 +229,7 @@ static void n_hdlc_release(struct n_hdlc *n_hdlc)
wake_up_interruptible (&tty->read_wait); wake_up_interruptible (&tty->read_wait);
wake_up_interruptible (&tty->write_wait); wake_up_interruptible (&tty->write_wait);
if (tty != NULL && tty->disc_data == n_hdlc) if (tty->disc_data == n_hdlc)
tty->disc_data = NULL; /* Break the tty->n_hdlc link */ tty->disc_data = NULL; /* Break the tty->n_hdlc link */
/* Release transmit and receive buffers */ /* Release transmit and receive buffers */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment