Commit 8388f290 authored by Linus Walleij's avatar Linus Walleij

gpio: em: Be sure to clamp return value

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Cc: Magnus Damm <damm@opensource.se>
Acked-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 5b8d8fb0
...@@ -203,7 +203,7 @@ static int em_gio_direction_input(struct gpio_chip *chip, unsigned offset) ...@@ -203,7 +203,7 @@ static int em_gio_direction_input(struct gpio_chip *chip, unsigned offset)
static int em_gio_get(struct gpio_chip *chip, unsigned offset) static int em_gio_get(struct gpio_chip *chip, unsigned offset)
{ {
return (int)(em_gio_read(gpio_to_priv(chip), GIO_I) & BIT(offset)); return !!(em_gio_read(gpio_to_priv(chip), GIO_I) & BIT(offset));
} }
static void __em_gio_set(struct gpio_chip *chip, unsigned int reg, static void __em_gio_set(struct gpio_chip *chip, unsigned int reg,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment