Commit 8510e30b authored by Al Viro's avatar Al Viro

last_radio_log: switch to proc_create()

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent ee21ed0a
...@@ -31,20 +31,8 @@ extern void *smem_item(unsigned id, unsigned *size); ...@@ -31,20 +31,8 @@ extern void *smem_item(unsigned id, unsigned *size);
static ssize_t last_radio_log_read(struct file *file, char __user *buf, static ssize_t last_radio_log_read(struct file *file, char __user *buf,
size_t len, loff_t *offset) size_t len, loff_t *offset)
{ {
loff_t pos = *offset; return simple_read_from_buffer(buf, len, offset,
ssize_t count; radio_log_base, radio_log_size);
if (pos >= radio_log_size)
return 0;
count = min(len, (size_t)(radio_log_size - pos));
if (copy_to_user(buf, radio_log_base + pos, count)) {
pr_err("%s: copy to user failed\n", __func__);
return -EFAULT;
}
*offset += count;
return count;
} }
static struct file_operations last_radio_log_fops = { static struct file_operations last_radio_log_fops = {
...@@ -67,7 +55,8 @@ void msm_init_last_radio_log(struct module *owner) ...@@ -67,7 +55,8 @@ void msm_init_last_radio_log(struct module *owner)
return; return;
} }
entry = create_proc_entry("last_radio_log", S_IFREG | S_IRUGO, NULL); entry = proc_create("last_radio_log", S_IRUGO, NULL,
&last_radio_log_fops);
if (!entry) { if (!entry) {
pr_err("%s: could not create proc entry for radio log\n", pr_err("%s: could not create proc entry for radio log\n",
__func__); __func__);
...@@ -77,7 +66,6 @@ void msm_init_last_radio_log(struct module *owner) ...@@ -77,7 +66,6 @@ void msm_init_last_radio_log(struct module *owner)
pr_err("%s: last radio log is %d bytes long\n", __func__, pr_err("%s: last radio log is %d bytes long\n", __func__,
radio_log_size); radio_log_size);
last_radio_log_fops.owner = owner; last_radio_log_fops.owner = owner;
entry->proc_fops = &last_radio_log_fops;
entry->size = radio_log_size; entry->size = radio_log_size;
} }
EXPORT_SYMBOL(msm_init_last_radio_log); EXPORT_SYMBOL(msm_init_last_radio_log);
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment