Commit 853eab68 authored by Wade Mealing's avatar Wade Mealing Committed by Greg Kroah-Hartman

Revert "zram: convert remaining CLASS_ATTR() to CLASS_ATTR_RO()"

Turns out that the permissions for 0400 really are what we want here,
otherwise any user can read from this file.

[fixed formatting, added changelog, and made attribute static - gregkh]
Reported-by: default avatarWade Mealing <wmealing@redhat.com>
Cc: stable <stable@vger.kernel.org>
Fixes: f40609d1 ("zram: convert remaining CLASS_ATTR() to CLASS_ATTR_RO()")
Link: https://bugzilla.redhat.com/show_bug.cgi?id=1847832Reviewed-by: default avatarSteffen Maier <maier@linux.ibm.com>
Acked-by: default avatarMinchan Kim <minchan@kernel.org>
Link: https://lore.kernel.org/r/20200617114946.GA2131650@kroah.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e852c2c2
...@@ -2021,7 +2021,8 @@ static ssize_t hot_add_show(struct class *class, ...@@ -2021,7 +2021,8 @@ static ssize_t hot_add_show(struct class *class,
return ret; return ret;
return scnprintf(buf, PAGE_SIZE, "%d\n", ret); return scnprintf(buf, PAGE_SIZE, "%d\n", ret);
} }
static CLASS_ATTR_RO(hot_add); static struct class_attribute class_attr_hot_add =
__ATTR(hot_add, 0400, hot_add_show, NULL);
static ssize_t hot_remove_store(struct class *class, static ssize_t hot_remove_store(struct class *class,
struct class_attribute *attr, struct class_attribute *attr,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment