Commit 86820a10 authored by Pan Bian's avatar Pan Bian Committed by Greg Kroah-Hartman

extcon: return error code on failure

commit 5b11ebed upstream.

Function get_zeroed_page() returns a NULL pointer if there is no enough
memory. In function extcon_sync(), it returns 0 if the call to
get_zeroed_page() fails. The return value 0 indicates success in the
context, which is incosistent with the execution status. This patch
fixes the bug by returning -ENOMEM.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188611Signed-off-by: default avatarPan Bian <bianpan2016@163.com>
Fixes: a580982fAcked-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ef8ee449
...@@ -453,7 +453,7 @@ int extcon_sync(struct extcon_dev *edev, unsigned int id) ...@@ -453,7 +453,7 @@ int extcon_sync(struct extcon_dev *edev, unsigned int id)
dev_err(&edev->dev, "out of memory in extcon_set_state\n"); dev_err(&edev->dev, "out of memory in extcon_set_state\n");
kobject_uevent(&edev->dev.kobj, KOBJ_CHANGE); kobject_uevent(&edev->dev.kobj, KOBJ_CHANGE);
return 0; return -ENOMEM;
} }
length = name_show(&edev->dev, NULL, prop_buf); length = name_show(&edev->dev, NULL, prop_buf);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment