Commit 8691a729 authored by Richard Purdie's avatar Richard Purdie Committed by David Woodhouse

[MTD] Add sync/unblank function to mtdoops

mtdoops wasn't ensuring data was flushed to flash in crash situations
after recent changes in mainline kernels as tracking the
oops_in_progress variable was no longer enough. We can use the "unblank"
console call as a sync call to tell us to write out the buffer though.

Therefore add a sync function to mtdoops and call this when console
unblank events occur.
Signed-off-by: default avatarRichard Purdie <rpurdie@openedhand.com>
Signed-off-by: default avatarDavid Woodhouse <dwmw2@infradead.org>
parent a2e96b62
...@@ -250,40 +250,50 @@ static void mtdoops_notify_remove(struct mtd_info *mtd) ...@@ -250,40 +250,50 @@ static void mtdoops_notify_remove(struct mtd_info *mtd)
flush_scheduled_work(); flush_scheduled_work();
} }
static void mtdoops_console_sync(void)
static void
mtdoops_console_write(struct console *co, const char *s, unsigned int count)
{ {
struct mtdoops_context *cxt = co->data; struct mtdoops_context *cxt = &oops_cxt;
struct mtd_info *mtd = cxt->mtd; struct mtd_info *mtd = cxt->mtd;
int i, ret; size_t retlen;
int ret;
if (!cxt->ready || !mtd) if (!cxt->ready || !mtd)
return; return;
if (!oops_in_progress && cxt->writecount != 0) { if (cxt->writecount == 0)
size_t retlen; return;
if (cxt->writecount < OOPS_PAGE_SIZE)
memset(cxt->oops_buf + cxt->writecount, 0xff, if (cxt->writecount < OOPS_PAGE_SIZE)
memset(cxt->oops_buf + cxt->writecount, 0xff,
OOPS_PAGE_SIZE - cxt->writecount); OOPS_PAGE_SIZE - cxt->writecount);
ret = mtd->write(mtd, cxt->nextpage * OOPS_PAGE_SIZE, ret = mtd->write(mtd, cxt->nextpage * OOPS_PAGE_SIZE,
OOPS_PAGE_SIZE, &retlen, cxt->oops_buf); OOPS_PAGE_SIZE, &retlen, cxt->oops_buf);
cxt->ready = 0; cxt->ready = 0;
cxt->writecount = 0; cxt->writecount = 0;
if ((retlen != OOPS_PAGE_SIZE) || (ret < 0)) if ((retlen != OOPS_PAGE_SIZE) || (ret < 0))
printk(KERN_ERR "mtdoops: Write failure at %d (%d of %d" printk(KERN_ERR "mtdoops: Write failure at %d (%d of %d written), err %d.\n",
" written), err %d.\n", cxt->nextpage * OOPS_PAGE_SIZE, retlen, OOPS_PAGE_SIZE, ret);
cxt->nextpage * OOPS_PAGE_SIZE, retlen,
OOPS_PAGE_SIZE, ret); ret = mtdoops_inc_counter(cxt);
if (ret == 1)
ret = mtdoops_inc_counter(cxt); schedule_work(&cxt->work);
if (ret == 1) }
schedule_work(&cxt->work);
static void
mtdoops_console_write(struct console *co, const char *s, unsigned int count)
{
struct mtdoops_context *cxt = co->data;
struct mtd_info *mtd = cxt->mtd;
int i;
if (!oops_in_progress) {
mtdoops_console_sync();
return;
} }
if (!oops_in_progress) if (!cxt->ready || !mtd)
return; return;
if (cxt->writecount == 0) { if (cxt->writecount == 0) {
...@@ -323,6 +333,7 @@ static struct console mtdoops_console = { ...@@ -323,6 +333,7 @@ static struct console mtdoops_console = {
.name = "ttyMTD", .name = "ttyMTD",
.write = mtdoops_console_write, .write = mtdoops_console_write,
.setup = mtdoops_console_setup, .setup = mtdoops_console_setup,
.unblank = mtdoops_console_sync,
.flags = CON_PRINTBUFFER, .flags = CON_PRINTBUFFER,
.index = -1, .index = -1,
.data = &oops_cxt, .data = &oops_cxt,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment