Commit 87a46909 authored by Guillaume Morin's avatar Guillaume Morin Committed by Jonathan Cameron

staging: iio: ad9850.c: code cleanup

checkpath.pl was complaining about value_mask:
ERROR: Macros with complex values should be enclosed in parenthesis

I fixed this by simply removing it since it's not used (as well as another
macro).  Got rid of the un-necessary error_ret label as well.
Signed-off-by: default avatarGuillaume Morin <guillaume@morinfr.org>
Reported-by: default avatarMichael Welling <mwelling@ieee.org>
Acked-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent fc167f62
...@@ -21,9 +21,6 @@ ...@@ -21,9 +21,6 @@
#define DRV_NAME "ad9850" #define DRV_NAME "ad9850"
#define value_mask (u16)0xf000
#define addr_shift 12
/* Register format: 4 bits addr + 12 bits value */ /* Register format: 4 bits addr + 12 bits value */
struct ad9850_config { struct ad9850_config {
u8 control[5]; u8 control[5];
...@@ -50,9 +47,6 @@ static ssize_t ad9850_set_parameter(struct device *dev, ...@@ -50,9 +47,6 @@ static ssize_t ad9850_set_parameter(struct device *dev,
mutex_lock(&st->lock); mutex_lock(&st->lock);
ret = spi_sync_transfer(st->sdev, &xfer, 1); ret = spi_sync_transfer(st->sdev, &xfer, 1);
if (ret)
goto error_ret;
error_ret:
mutex_unlock(&st->lock); mutex_unlock(&st->lock);
return ret ? ret : len; return ret ? ret : len;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment