Commit 8811249f authored by Ian Kent's avatar Ian Kent Committed by Al Viro

vfs: update d_make_root() description

Clearify d_make_root() usage, error handling and cleanup
requirements.
Signed-off-by: default avatarIan Kent <raven@themaw.net>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent a188339c
...@@ -428,8 +428,19 @@ release it yourself. ...@@ -428,8 +428,19 @@ release it yourself.
-- --
[mandatory] [mandatory]
d_alloc_root() is gone, along with a lot of bugs caused by code d_alloc_root() is gone, along with a lot of bugs caused by code
misusing it. Replacement: d_make_root(inode). The difference is, misusing it. Replacement: d_make_root(inode). On success d_make_root(inode)
d_make_root() drops the reference to inode if dentry allocation fails. allocates and returns a new dentry instantiated with the passed in inode.
On failure NULL is returned and the passed in inode is dropped so the reference
to inode is consumed in all cases and failure handling need not do any cleanup
for the inode. If d_make_root(inode) is passed a NULL inode it returns NULL
and also requires no further error handling. Typical usage is:
inode = foofs_new_inode(....);
s->s_root = d_make_inode(inode);
if (!s->s_root)
/* Nothing needed for the inode cleanup */
return -ENOMEM;
...
-- --
[mandatory] [mandatory]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment