Commit 893473df authored by Dave Hansen's avatar Dave Hansen Committed by Benjamin Herrenschmidt

powerpc/mm: Cleanup careful_allocation(): consolidate memset()

Both users of careful_allocation() immediately memset() the
result.  So, just do it in one place.

Also give careful_allocation() a 'z' prefix to bring it in
line with kzmalloc() and friends.
Signed-off-by: default avatarDave Hansen <dave@linux.vnet.ibm.com>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent 0be210fd
...@@ -824,7 +824,7 @@ static void __init dump_numa_memory_topology(void) ...@@ -824,7 +824,7 @@ static void __init dump_numa_memory_topology(void)
* *
* Returns the virtual address of the memory. * Returns the virtual address of the memory.
*/ */
static void __init *careful_allocation(int nid, unsigned long size, static void __init *careful_zallocation(int nid, unsigned long size,
unsigned long align, unsigned long align,
unsigned long end_pfn) unsigned long end_pfn)
{ {
...@@ -864,6 +864,7 @@ static void __init *careful_allocation(int nid, unsigned long size, ...@@ -864,6 +864,7 @@ static void __init *careful_allocation(int nid, unsigned long size,
dbg("alloc_bootmem %p %lx\n", ret, size); dbg("alloc_bootmem %p %lx\n", ret, size);
} }
memset(ret, 0, size);
return ret; return ret;
} }
...@@ -971,10 +972,9 @@ void __init do_init_bootmem(void) ...@@ -971,10 +972,9 @@ void __init do_init_bootmem(void)
* previous nodes' bootmem to be initialized and have * previous nodes' bootmem to be initialized and have
* all reserved areas marked. * all reserved areas marked.
*/ */
NODE_DATA(nid) = careful_allocation(nid, NODE_DATA(nid) = careful_zallocation(nid,
sizeof(struct pglist_data), sizeof(struct pglist_data),
SMP_CACHE_BYTES, end_pfn); SMP_CACHE_BYTES, end_pfn);
memset(NODE_DATA(nid), 0, sizeof(struct pglist_data));
dbg("node %d\n", nid); dbg("node %d\n", nid);
dbg("NODE_DATA() = %p\n", NODE_DATA(nid)); dbg("NODE_DATA() = %p\n", NODE_DATA(nid));
...@@ -990,10 +990,9 @@ void __init do_init_bootmem(void) ...@@ -990,10 +990,9 @@ void __init do_init_bootmem(void)
dbg("end_paddr = %lx\n", end_pfn << PAGE_SHIFT); dbg("end_paddr = %lx\n", end_pfn << PAGE_SHIFT);
bootmap_pages = bootmem_bootmap_pages(end_pfn - start_pfn); bootmap_pages = bootmem_bootmap_pages(end_pfn - start_pfn);
bootmem_vaddr = careful_allocation(nid, bootmem_vaddr = careful_zallocation(nid,
bootmap_pages << PAGE_SHIFT, bootmap_pages << PAGE_SHIFT,
PAGE_SIZE, end_pfn); PAGE_SIZE, end_pfn);
memset(bootmem_vaddr, 0, bootmap_pages << PAGE_SHIFT);
dbg("bootmap_vaddr = %p\n", bootmem_vaddr); dbg("bootmap_vaddr = %p\n", bootmem_vaddr);
...@@ -1004,7 +1003,7 @@ void __init do_init_bootmem(void) ...@@ -1004,7 +1003,7 @@ void __init do_init_bootmem(void)
free_bootmem_with_active_regions(nid, end_pfn); free_bootmem_with_active_regions(nid, end_pfn);
/* /*
* Be very careful about moving this around. Future * Be very careful about moving this around. Future
* calls to careful_allocation() depend on this getting * calls to careful_zallocation() depend on this getting
* done correctly. * done correctly.
*/ */
mark_reserved_regions_for_nid(nid); mark_reserved_regions_for_nid(nid);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment