Commit 8a0a1f84 authored by Julia Lawall's avatar Julia Lawall Committed by David S. Miller

net: Xilinx: fix error return code

Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4e4804be
...@@ -1043,6 +1043,7 @@ static int temac_of_probe(struct platform_device *op) ...@@ -1043,6 +1043,7 @@ static int temac_of_probe(struct platform_device *op)
lp->regs = of_iomap(op->dev.of_node, 0); lp->regs = of_iomap(op->dev.of_node, 0);
if (!lp->regs) { if (!lp->regs) {
dev_err(&op->dev, "could not map temac regs.\n"); dev_err(&op->dev, "could not map temac regs.\n");
rc = -ENOMEM;
goto nodev; goto nodev;
} }
...@@ -1062,6 +1063,7 @@ static int temac_of_probe(struct platform_device *op) ...@@ -1062,6 +1063,7 @@ static int temac_of_probe(struct platform_device *op)
np = of_parse_phandle(op->dev.of_node, "llink-connected", 0); np = of_parse_phandle(op->dev.of_node, "llink-connected", 0);
if (!np) { if (!np) {
dev_err(&op->dev, "could not find DMA node\n"); dev_err(&op->dev, "could not find DMA node\n");
rc = -ENODEV;
goto err_iounmap; goto err_iounmap;
} }
......
...@@ -1109,6 +1109,7 @@ static int xemaclite_of_probe(struct platform_device *ofdev) ...@@ -1109,6 +1109,7 @@ static int xemaclite_of_probe(struct platform_device *ofdev)
res = platform_get_resource(ofdev, IORESOURCE_IRQ, 0); res = platform_get_resource(ofdev, IORESOURCE_IRQ, 0);
if (!res) { if (!res) {
dev_err(dev, "no IRQ found\n"); dev_err(dev, "no IRQ found\n");
rc = -ENXIO;
goto error; goto error;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment