Commit 8bfaecf0 authored by Stephen Hemminger's avatar Stephen Hemminger

[PATCH] trivial -- skfp_probe should be static

skfp_probe used to be called from Space.c but isn't any more.
Therefore it no longer needs to be global.  All the calls to insert_device()
pass skfp_probe as a second arg, so just use it directly.

Jeff, this also is janitor type stuff, so just put it in net-2.5-exp
parent 6ff26020
...@@ -106,14 +106,9 @@ static const char *boot_msg = ...@@ -106,14 +106,9 @@ static const char *boot_msg =
#include "h/smtstate.h" #include "h/smtstate.h"
// Define global routines
int skfp_probe(struct net_device *dev);
// Define module-wide (static) routines // Define module-wide (static) routines
static struct net_device *alloc_device(struct net_device *dev, u_long iobase); static struct net_device *alloc_device(struct net_device *dev, u_long iobase);
static struct net_device *insert_device(struct net_device *dev, static struct net_device *insert_device(struct net_device *dev);
int (*init) (struct net_device *));
static int fddi_dev_index(unsigned char *s); static int fddi_dev_index(unsigned char *s);
static void init_dev(struct net_device *dev, u_long iobase); static void init_dev(struct net_device *dev, u_long iobase);
static void link_modules(struct net_device *dev, struct net_device *tmp); static void link_modules(struct net_device *dev, struct net_device *tmp);
...@@ -259,7 +254,7 @@ static int loading_module; ...@@ -259,7 +254,7 @@ static int loading_module;
* initialized and the board resources are read and stored in * initialized and the board resources are read and stored in
* the device structure. * the device structure.
*/ */
int skfp_probe(struct net_device *dev) static int skfp_probe(struct net_device *dev)
{ {
int i; /* used in for loops */ int i; /* used in for loops */
struct pci_dev *pdev = NULL; /* PCI device structure */ struct pci_dev *pdev = NULL; /* PCI device structure */
...@@ -453,7 +448,7 @@ static struct net_device *alloc_device(struct net_device *dev, u_long iobase) ...@@ -453,7 +448,7 @@ static struct net_device *alloc_device(struct net_device *dev, u_long iobase)
num_fddi = fddi_dev_index(dev->name); num_fddi = fddi_dev_index(dev->name);
if (loading_module) { if (loading_module) {
num_fddi++; num_fddi++;
dev = insert_device(dev, skfp_probe); dev = insert_device(dev);
return dev; return dev;
} }
while (1) { while (1) {
...@@ -484,7 +479,7 @@ static struct net_device *alloc_device(struct net_device *dev, u_long iobase) ...@@ -484,7 +479,7 @@ static struct net_device *alloc_device(struct net_device *dev, u_long iobase)
(dev->base_addr != 0)) && !fixed) || (dev->base_addr != 0)) && !fixed) ||
new_dev) { new_dev) {
num_fddi++; /* New device */ num_fddi++; /* New device */
dev = insert_device(dev, skfp_probe); dev = insert_device(dev);
} }
if (dev) { if (dev) {
if (!dev->priv) { if (!dev->priv) {
...@@ -550,8 +545,7 @@ static void init_dev(struct net_device *dev, u_long iobase) ...@@ -550,8 +545,7 @@ static void init_dev(struct net_device *dev, u_long iobase)
* one up. If memory could not be allocated, print an error message. * one up. If memory could not be allocated, print an error message.
* *
************************/ ************************/
static struct net_device *insert_device(struct net_device *dev, static struct net_device *insert_device(struct net_device *dev)
int (*init) (struct net_device *))
{ {
struct net_device *new; struct net_device *new;
int len; int len;
...@@ -566,7 +560,7 @@ static struct net_device *insert_device(struct net_device *dev, ...@@ -566,7 +560,7 @@ static struct net_device *insert_device(struct net_device *dev,
} else { } else {
memset((char *) new, 0, len); memset((char *) new, 0, len);
new->priv = (struct s_smc *) (new + 1); new->priv = (struct s_smc *) (new + 1);
new->init = init; /* initialisation routine */ new->init = skfp_probe;
if (!loading_module) { if (!loading_module) {
new->next = dev->next; new->next = dev->next;
dev->next = new; dev->next = new;
...@@ -2545,7 +2539,7 @@ static int __init skfd_init(void) ...@@ -2545,7 +2539,7 @@ static int __init skfd_init(void)
{ {
struct net_device *p; struct net_device *p;
if ((mdev = insert_device(NULL, skfp_probe)) == NULL) if ((mdev = insert_device(NULL)) == NULL)
return -ENOMEM; return -ENOMEM;
for (p = mdev; p != NULL; p = ((struct s_smc *)p->priv)->os.next_module) { for (p = mdev; p != NULL; p = ((struct s_smc *)p->priv)->os.next_module) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment