Commit 8ce39eb5 authored by Navid Emamdoost's avatar Navid Emamdoost Committed by David S. Miller

nfp: flower: fix memory leak in nfp_flower_spawn_vnic_reprs

In nfp_flower_spawn_vnic_reprs in the loop if initialization or the
allocations fail memory is leaked. Appropriate releases are added.

Fixes: b9452452 ("nfp: flower: add per repr private data for LAG offload")
Signed-off-by: default avatarNavid Emamdoost <navid.emamdoost@gmail.com>
Acked-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8572cea1
...@@ -400,6 +400,7 @@ nfp_flower_spawn_vnic_reprs(struct nfp_app *app, ...@@ -400,6 +400,7 @@ nfp_flower_spawn_vnic_reprs(struct nfp_app *app,
repr_priv = kzalloc(sizeof(*repr_priv), GFP_KERNEL); repr_priv = kzalloc(sizeof(*repr_priv), GFP_KERNEL);
if (!repr_priv) { if (!repr_priv) {
err = -ENOMEM; err = -ENOMEM;
nfp_repr_free(repr);
goto err_reprs_clean; goto err_reprs_clean;
} }
...@@ -413,6 +414,7 @@ nfp_flower_spawn_vnic_reprs(struct nfp_app *app, ...@@ -413,6 +414,7 @@ nfp_flower_spawn_vnic_reprs(struct nfp_app *app,
port = nfp_port_alloc(app, port_type, repr); port = nfp_port_alloc(app, port_type, repr);
if (IS_ERR(port)) { if (IS_ERR(port)) {
err = PTR_ERR(port); err = PTR_ERR(port);
kfree(repr_priv);
nfp_repr_free(repr); nfp_repr_free(repr);
goto err_reprs_clean; goto err_reprs_clean;
} }
...@@ -433,6 +435,7 @@ nfp_flower_spawn_vnic_reprs(struct nfp_app *app, ...@@ -433,6 +435,7 @@ nfp_flower_spawn_vnic_reprs(struct nfp_app *app,
err = nfp_repr_init(app, repr, err = nfp_repr_init(app, repr,
port_id, port, priv->nn->dp.netdev); port_id, port, priv->nn->dp.netdev);
if (err) { if (err) {
kfree(repr_priv);
nfp_port_free(port); nfp_port_free(port);
nfp_repr_free(repr); nfp_repr_free(repr);
goto err_reprs_clean; goto err_reprs_clean;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment