Commit 8d5cfd7f authored by Manfred Rudigier's avatar Manfred Rudigier Committed by Jeff Kirsher

igb: Fix constant media auto sense switching when no cable is connected

At least on the i350 there is an annoying behavior that is maybe also
present on 82580 devices, but was probably not noticed yet as MAS is not
widely used.

If no cable is connected on both fiber/copper ports the media auto sense
code will constantly swap between them as part of the watchdog task and
produce many unnecessary kernel log messages.

The swap code responsible for this behavior (switching to fiber) should
not be executed if the current media type is copper and there is no signal
detected on the fiber port. In this case we can safely wait until the
AUTOSENSE_EN bit is cleared.
Signed-off-by: default avatarManfred Rudigier <manfred.rudigier@omicronenergy.com>
Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent fb2308ba
...@@ -2065,7 +2065,8 @@ static void igb_check_swap_media(struct igb_adapter *adapter) ...@@ -2065,7 +2065,8 @@ static void igb_check_swap_media(struct igb_adapter *adapter)
if ((hw->phy.media_type == e1000_media_type_copper) && if ((hw->phy.media_type == e1000_media_type_copper) &&
(!(connsw & E1000_CONNSW_AUTOSENSE_EN))) { (!(connsw & E1000_CONNSW_AUTOSENSE_EN))) {
swap_now = true; swap_now = true;
} else if (!(connsw & E1000_CONNSW_SERDESD)) { } else if ((hw->phy.media_type != e1000_media_type_copper) &&
!(connsw & E1000_CONNSW_SERDESD)) {
/* copper signal takes time to appear */ /* copper signal takes time to appear */
if (adapter->copper_tries < 4) { if (adapter->copper_tries < 4) {
adapter->copper_tries++; adapter->copper_tries++;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment