Commit 8ef58b82 authored by Matthew Wilcox (Oracle)'s avatar Matthew Wilcox (Oracle) Committed by Greg Kroah-Hartman

idr: Fix idr_alloc_u32 on 32-bit systems

[ Upstream commit b7e9728f ]

Attempting to allocate an entry at 0xffffffff when one is already
present would succeed in allocating one at 2^32, which would confuse
everything.  Return -ENOSPC in this case, as expected.
Signed-off-by: default avatarMatthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 88358c76
...@@ -2172,7 +2172,7 @@ void __rcu **idr_get_free(struct radix_tree_root *root, ...@@ -2172,7 +2172,7 @@ void __rcu **idr_get_free(struct radix_tree_root *root,
offset = radix_tree_find_next_bit(node, IDR_FREE, offset = radix_tree_find_next_bit(node, IDR_FREE,
offset + 1); offset + 1);
start = next_index(start, node, offset); start = next_index(start, node, offset);
if (start > max) if (start > max || start == 0)
return ERR_PTR(-ENOSPC); return ERR_PTR(-ENOSPC);
while (offset == RADIX_TREE_MAP_SIZE) { while (offset == RADIX_TREE_MAP_SIZE) {
offset = node->offset + 1; offset = node->offset + 1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment