Commit 93052132 authored by Dave Airlie's avatar Dave Airlie Committed by Alex Deucher

amdgpu/dc: convert dc_transfer to use a kref.

Rolling your own atomic ref counts is frowned upon.
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
Reviewed-by: default avatarHarry Wentland <harry.wentland@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 5d15ae23
...@@ -161,17 +161,18 @@ struct dc_gamma *dc_create_gamma() ...@@ -161,17 +161,18 @@ struct dc_gamma *dc_create_gamma()
void dc_transfer_func_retain(struct dc_transfer_func *tf) void dc_transfer_func_retain(struct dc_transfer_func *tf)
{ {
ASSERT(atomic_read(&tf->ref_count) > 0); kref_get(&tf->refcount);
atomic_inc(&tf->ref_count);
} }
void dc_transfer_func_release(struct dc_transfer_func *tf) static void dc_transfer_func_free(struct kref *kref)
{ {
ASSERT(atomic_read(&tf->ref_count) > 0); struct dc_transfer_func *tf = container_of(kref, struct dc_transfer_func, refcount);
atomic_dec(&tf->ref_count); kfree(tf);
}
if (atomic_read(&tf->ref_count) == 0) void dc_transfer_func_release(struct dc_transfer_func *tf)
kfree(tf); {
kref_put(&tf->refcount, dc_transfer_func_free);
} }
struct dc_transfer_func *dc_create_transfer_func() struct dc_transfer_func *dc_create_transfer_func()
...@@ -181,7 +182,7 @@ struct dc_transfer_func *dc_create_transfer_func() ...@@ -181,7 +182,7 @@ struct dc_transfer_func *dc_create_transfer_func()
if (tf == NULL) if (tf == NULL)
goto alloc_fail; goto alloc_fail;
atomic_inc(&tf->ref_count); kref_init(&tf->refcount);
return tf; return tf;
......
...@@ -330,11 +330,11 @@ enum dc_transfer_func_predefined { ...@@ -330,11 +330,11 @@ enum dc_transfer_func_predefined {
}; };
struct dc_transfer_func { struct dc_transfer_func {
struct kref refcount;
struct dc_transfer_func_distributed_points tf_pts; struct dc_transfer_func_distributed_points tf_pts;
enum dc_transfer_func_type type; enum dc_transfer_func_type type;
enum dc_transfer_func_predefined tf; enum dc_transfer_func_predefined tf;
struct dc_context *ctx; struct dc_context *ctx;
atomic_t ref_count;
}; };
/* /*
......
...@@ -32,6 +32,8 @@ ...@@ -32,6 +32,8 @@
#include <linux/types.h> #include <linux/types.h>
#include <drm/drmP.h> #include <drm/drmP.h>
#include <linux/kref.h>
#include "cgs_linux.h" #include "cgs_linux.h"
#if defined(__BIG_ENDIAN) && !defined(BIGENDIAN_CPU) #if defined(__BIG_ENDIAN) && !defined(BIGENDIAN_CPU)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment