Commit 94459a97 authored by Peter Hurley's avatar Peter Hurley Committed by Greg Kroah-Hartman

drivers/misc/ti-st: Prefer tty_driver_flush_buffer

The tty core provides an interface for flushing the driver's
write buffer: tty_driver_flush_buffer(); prefer the provided
interface over open-coded. Open-coding can lead to errors
such as the duplicated call in the st_kim driver.
Signed-off-by: default avatarPeter Hurley <peter@hurleysoftware.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 10ee9074
...@@ -812,7 +812,7 @@ static void st_tty_flush_buffer(struct tty_struct *tty) ...@@ -812,7 +812,7 @@ static void st_tty_flush_buffer(struct tty_struct *tty)
kfree_skb(st_gdata->tx_skb); kfree_skb(st_gdata->tx_skb);
st_gdata->tx_skb = NULL; st_gdata->tx_skb = NULL;
tty->ops->flush_buffer(tty); tty_driver_flush_buffer(tty);
return; return;
} }
......
...@@ -531,7 +531,6 @@ long st_kim_stop(void *kim_data) ...@@ -531,7 +531,6 @@ long st_kim_stop(void *kim_data)
/* Flush any pending characters in the driver and discipline. */ /* Flush any pending characters in the driver and discipline. */
tty_ldisc_flush(tty); tty_ldisc_flush(tty);
tty_driver_flush_buffer(tty); tty_driver_flush_buffer(tty);
tty->ops->flush_buffer(tty);
} }
/* send uninstall notification to UIM */ /* send uninstall notification to UIM */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment