Commit 94a6735c authored by Jesper Juhl's avatar Jesper Juhl Committed by Linus Torvalds

[PATCH] i4l: memory leak fix for sc_ioctl().

Fix leak of `rcvmsg' in sc_ioctl().

There are two returns in the switch in sc_ioctl (the SCIOCSTART case) that
may leak `rcvmsg'.  This patch fixes that by adding a kfree() call at the
beginning of that case.

Bug found by the coverity checker as #1098

Eric Sesterhenn send me a patch to fix the leak(s) by adding 2 kfree()
calls before the returns, I changed that into just a single call at the
beginning.
Signed-off-by: default avatarJesper Juhl <jesper.juhl@gmail.com>
Cc: Karsten Keil <kkeil@suse.de>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 2eebb192
...@@ -97,6 +97,7 @@ int sc_ioctl(int card, scs_ioctl *data) ...@@ -97,6 +97,7 @@ int sc_ioctl(int card, scs_ioctl *data)
case SCIOCSTART: case SCIOCSTART:
{ {
kfree(rcvmsg);
pr_debug("%s: SCIOSTART: ioctl received\n", pr_debug("%s: SCIOSTART: ioctl received\n",
sc_adapter[card]->devicename); sc_adapter[card]->devicename);
if(sc_adapter[card]->EngineUp) { if(sc_adapter[card]->EngineUp) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment