Commit 955cbe91 authored by Tanner Love's avatar Tanner Love Committed by David S. Miller

selftests/net: rxtimestamp: fix clang issues for target arch PowerPC

The signedness of char is implementation-dependent. Some systems
(including PowerPC and ARM) use unsigned char. Clang 9 threw:
warning: result of comparison of constant -1 with expression of type \
'char' is always true [-Wtautological-constant-out-of-range-compare]
                                  &arg_index)) != -1) {

Tested: make -C tools/testing/selftests TARGETS="net" run_tests

Fixes: 16e78122 ("selftests/net: Add a test to validate behavior of rx timestamps")
Signed-off-by: default avatarTanner Love <tannerlove@google.com>
Acked-by: default avatarWillem de Bruijn <willemb@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5fd82200
...@@ -329,8 +329,7 @@ int main(int argc, char **argv) ...@@ -329,8 +329,7 @@ int main(int argc, char **argv)
bool all_tests = true; bool all_tests = true;
int arg_index = 0; int arg_index = 0;
int failures = 0; int failures = 0;
int s, t; int s, t, opt;
char opt;
while ((opt = getopt_long(argc, argv, "", long_options, while ((opt = getopt_long(argc, argv, "", long_options,
&arg_index)) != -1) { &arg_index)) != -1) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment