Commit 960e1c4d authored by Romain Izard's avatar Romain Izard Committed by Stephen Boyd

clk: at91: pmc: Wait for clocks when resuming

Wait for the syncronization of all clocks when resuming, not only the
UPLL clock. Do not use regmap_read_poll_timeout, as it will call BUG()
when interrupts are masked, which is the case in here.
Signed-off-by: default avatarRomain Izard <romain.izard.pro@gmail.com>
Acked-by: default avatarLudovic Desroches <ludovic.desroches@microchip.com>
Acked-by: default avatarNicolas Ferre <nicolas.ferre@microchip.com>
Acked-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
parent 4fbd8d19
...@@ -107,10 +107,20 @@ static int pmc_suspend(void) ...@@ -107,10 +107,20 @@ static int pmc_suspend(void)
return 0; return 0;
} }
static bool pmc_ready(unsigned int mask)
{
unsigned int status;
regmap_read(pmcreg, AT91_PMC_SR, &status);
return ((status & mask) == mask) ? 1 : 0;
}
static void pmc_resume(void) static void pmc_resume(void)
{ {
int i, ret = 0; int i;
u32 tmp; u32 tmp;
u32 mask = AT91_PMC_MCKRDY | AT91_PMC_LOCKA;
regmap_read(pmcreg, AT91_PMC_MCKR, &tmp); regmap_read(pmcreg, AT91_PMC_MCKR, &tmp);
if (pmc_cache.mckr != tmp) if (pmc_cache.mckr != tmp)
...@@ -134,13 +144,11 @@ static void pmc_resume(void) ...@@ -134,13 +144,11 @@ static void pmc_resume(void)
AT91_PMC_PCR_CMD); AT91_PMC_PCR_CMD);
} }
if (pmc_cache.uckr & AT91_PMC_UPLLEN) { if (pmc_cache.uckr & AT91_PMC_UPLLEN)
ret = regmap_read_poll_timeout(pmcreg, AT91_PMC_SR, tmp, mask |= AT91_PMC_LOCKU;
!(tmp & AT91_PMC_LOCKU),
10, 5000); while (!pmc_ready(mask))
if (ret) cpu_relax();
pr_crit("USB PLL didn't lock when resuming\n");
}
} }
static struct syscore_ops pmc_syscore_ops = { static struct syscore_ops pmc_syscore_ops = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment