Commit 968339fa authored by Fangrui Song's avatar Fangrui Song Committed by Michael Ellerman

powerpc/boot: Delete unneeded .globl _zimage_start

.globl sets the symbol binding to STB_GLOBAL while .weak sets the
binding to STB_WEAK. GNU as let .weak override .globl since
binutils-gdb 5ca547dc2399a0a5d9f20626d4bf5547c3ccfddd (1996). Clang
integrated assembler let the last win but it may error in the future.

Since it is a convention that only one binding directive is used, just
delete .globl.

Fixes: ee9d21b3 ("powerpc/boot: Ensure _zimage_start is a weak symbol")
Signed-off-by: default avatarFangrui Song <maskray@google.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20200325164257.170229-1-maskray@google.com
parent efbc4303
...@@ -44,9 +44,6 @@ p_end: .long _end ...@@ -44,9 +44,6 @@ p_end: .long _end
p_pstack: .long _platform_stack_top p_pstack: .long _platform_stack_top
#endif #endif
.globl _zimage_start
/* Clang appears to require the .weak directive to be after the symbol
* is defined. See https://bugs.llvm.org/show_bug.cgi?id=38921 */
.weak _zimage_start .weak _zimage_start
_zimage_start: _zimage_start:
.globl _zimage_start_lib .globl _zimage_start_lib
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment