Commit 9712c092 authored by Stephen Boyd's avatar Stephen Boyd Committed by Greg Kroah-Hartman

coresight: Avoid casting void pointers

We don't need to cast void pointers, such as the amba_id data. Assign to
a local variable to make the code prettier and also return NULL instead
of 0 to make sparse happy.

Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Mike Leach <mike.leach@linaro.org>
Reviewed-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarStephen Boyd <swboyd@chromium.org>
Reviewed-by: default avatarMike Leach <mike.leach@linaro.org>
Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
Link: https://lore.kernel.org/r/20200518180242.7916-21-mathieu.poirier@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 298754c5
...@@ -215,9 +215,12 @@ cti_remove_assoc_from_csdev(struct coresight_device *csdev) {} ...@@ -215,9 +215,12 @@ cti_remove_assoc_from_csdev(struct coresight_device *csdev) {}
/* extract the data value from a UCI structure given amba_id pointer. */ /* extract the data value from a UCI structure given amba_id pointer. */
static inline void *coresight_get_uci_data(const struct amba_id *id) static inline void *coresight_get_uci_data(const struct amba_id *id)
{ {
if (id->data) struct amba_cs_uci_id *uci_id = id->data;
return ((struct amba_cs_uci_id *)(id->data))->data;
return 0; if (!uci_id)
return NULL;
return uci_id->data;
} }
void coresight_release_platform_data(struct coresight_device *csdev, void coresight_release_platform_data(struct coresight_device *csdev,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment