Commit 977a6ef3 authored by Xiaochen Wang's avatar Xiaochen Wang Committed by Takashi Iwai

sound: read i_size with i_size_read()

Convert direct read of inode->i_size to using i_size_read().
i_size_read is guaranteed to return a valid value and
its caller does not need to use addtional locking.
Signed-off-by: default avatarXiaochen Wang <wangxiaochen0@gmail.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent d351cf46
...@@ -19,7 +19,7 @@ static int do_mod_firmware_load(const char *fn, char **fp) ...@@ -19,7 +19,7 @@ static int do_mod_firmware_load(const char *fn, char **fp)
printk(KERN_INFO "Unable to load '%s'.\n", fn); printk(KERN_INFO "Unable to load '%s'.\n", fn);
return 0; return 0;
} }
l = filp->f_path.dentry->d_inode->i_size; l = i_size_read(filp->f_path.dentry->d_inode);
if (l <= 0 || l > 131072) if (l <= 0 || l > 131072)
{ {
printk(KERN_INFO "Invalid firmware '%s'\n", fn); printk(KERN_INFO "Invalid firmware '%s'\n", fn);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment