Commit 977bc20c authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller

mediatek: checking for IS_ERR() instead of NULL

of_phy_connect() returns NULL on error, it never returns error pointers.

Fixes: 656e7052 ('net-next: mediatek: add support for MT7623 ethernet')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarJohn Crispin <blogic@openwrt.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fe3a5f6c
...@@ -186,9 +186,9 @@ static int mtk_phy_connect_node(struct mtk_eth *eth, struct mtk_mac *mac, ...@@ -186,9 +186,9 @@ static int mtk_phy_connect_node(struct mtk_eth *eth, struct mtk_mac *mac,
phydev = of_phy_connect(eth->netdev[mac->id], phy_node, phydev = of_phy_connect(eth->netdev[mac->id], phy_node,
mtk_phy_link_adjust, 0, phy_mode); mtk_phy_link_adjust, 0, phy_mode);
if (IS_ERR(phydev)) { if (!phydev) {
dev_err(eth->dev, "could not connect to PHY\n"); dev_err(eth->dev, "could not connect to PHY\n");
return PTR_ERR(phydev); return -ENODEV;
} }
dev_info(eth->dev, dev_info(eth->dev,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment