Commit 9927c893 authored by Ben Hutchings's avatar Ben Hutchings Committed by David S. Miller

ethtool: Make struct ethtool_rxnfc kernel-doc more self-consistent

Refer consistently to 'classification rules' or just 'rules' rather
than 'filter specifications' or 'filter rules'.

Refer consistently to rule 'locations' and not 'indices'.
Signed-off-by: default avatarBen Hutchings <bhutchings@solarflare.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 956a2066
...@@ -446,7 +446,7 @@ struct ethtool_flow_ext { ...@@ -446,7 +446,7 @@ struct ethtool_flow_ext {
}; };
/** /**
* struct ethtool_rx_flow_spec - specification for RX flow filter * struct ethtool_rx_flow_spec - classification rule for RX flows
* @flow_type: Type of match to perform, e.g. %TCP_V4_FLOW * @flow_type: Type of match to perform, e.g. %TCP_V4_FLOW
* @h_u: Flow fields to match (dependent on @flow_type) * @h_u: Flow fields to match (dependent on @flow_type)
* @h_ext: Additional fields to match * @h_ext: Additional fields to match
...@@ -456,7 +456,7 @@ struct ethtool_flow_ext { ...@@ -456,7 +456,7 @@ struct ethtool_flow_ext {
* includes the %FLOW_EXT flag. * includes the %FLOW_EXT flag.
* @ring_cookie: RX ring/queue index to deliver to, or %RX_CLS_FLOW_DISC * @ring_cookie: RX ring/queue index to deliver to, or %RX_CLS_FLOW_DISC
* if packets should be discarded * if packets should be discarded
* @location: Index of filter in hardware table * @location: Location of rule in the table
*/ */
struct ethtool_rx_flow_spec { struct ethtool_rx_flow_spec {
__u32 flow_type; __u32 flow_type;
...@@ -475,9 +475,9 @@ struct ethtool_rx_flow_spec { ...@@ -475,9 +475,9 @@ struct ethtool_rx_flow_spec {
* %ETHTOOL_GRXCLSRLALL, %ETHTOOL_SRXCLSRLDEL or %ETHTOOL_SRXCLSRLINS * %ETHTOOL_GRXCLSRLALL, %ETHTOOL_SRXCLSRLDEL or %ETHTOOL_SRXCLSRLINS
* @flow_type: Type of flow to be affected, e.g. %TCP_V4_FLOW * @flow_type: Type of flow to be affected, e.g. %TCP_V4_FLOW
* @data: Command-dependent value * @data: Command-dependent value
* @fs: Flow filter specification * @fs: Flow classification rule
* @rule_cnt: Number of rules to be affected * @rule_cnt: Number of rules to be affected
* @rule_locs: Array of valid rule indices * @rule_locs: Array of valid rule locations
* *
* For %ETHTOOL_GRXFH and %ETHTOOL_SRXFH, @data is a bitmask indicating * For %ETHTOOL_GRXFH and %ETHTOOL_SRXFH, @data is a bitmask indicating
* the fields included in the flow hash, e.g. %RXH_IP_SRC. The following * the fields included in the flow hash, e.g. %RXH_IP_SRC. The following
...@@ -489,20 +489,19 @@ struct ethtool_rx_flow_spec { ...@@ -489,20 +489,19 @@ struct ethtool_rx_flow_spec {
* For %ETHTOOL_GRXCLSRLCNT, @rule_cnt is set to the number of defined * For %ETHTOOL_GRXCLSRLCNT, @rule_cnt is set to the number of defined
* rules on return. * rules on return.
* *
* For %ETHTOOL_GRXCLSRULE, @fs.@location specifies the index of an * For %ETHTOOL_GRXCLSRULE, @fs.@location specifies the location of an
* existing filter rule on entry and @fs contains the rule on return. * existing rule on entry and @fs contains the rule on return.
* *
* For %ETHTOOL_GRXCLSRLALL, @rule_cnt specifies the array size of the * For %ETHTOOL_GRXCLSRLALL, @rule_cnt specifies the array size of the
* user buffer for @rule_locs on entry. On return, @data is the size * user buffer for @rule_locs on entry. On return, @data is the size
* of the filter table and @rule_locs contains the indices of the * of the rule table and @rule_locs contains the locations of the
* defined rules. * defined rules.
* *
* For %ETHTOOL_SRXCLSRLINS, @fs specifies the filter rule to add or * For %ETHTOOL_SRXCLSRLINS, @fs specifies the rule to add or update.
* update. @fs.@location specifies the index to use and must not be * @fs.@location specifies the location to use and must not be ignored.
* ignored.
* *
* For %ETHTOOL_SRXCLSRLDEL, @fs.@location specifies the index of an * For %ETHTOOL_SRXCLSRLDEL, @fs.@location specifies the location of an
* existing filter rule on entry. * existing rule on entry.
* *
* Implementation of indexed classification rules generally requires a * Implementation of indexed classification rules generally requires a
* TCAM. * TCAM.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment