Commit 99913a17 authored by Dave Airlie's avatar Dave Airlie Committed by Alex Deucher

amdgpu/dc: make dce80 timing generator construct return void.

Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
Reviewed-by: default avatarHarry Wentland <harry.wentland@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 5fb005c4
...@@ -404,12 +404,8 @@ static struct timing_generator *dce80_timing_generator_create( ...@@ -404,12 +404,8 @@ static struct timing_generator *dce80_timing_generator_create(
if (!tg110) if (!tg110)
return NULL; return NULL;
if (dce80_timing_generator_construct(tg110, ctx, instance, offsets)) dce80_timing_generator_construct(tg110, ctx, instance, offsets);
return &tg110->base; return &tg110->base;
BREAK_TO_DEBUGGER();
kfree(tg110);
return NULL;
} }
static struct output_pixel_processor *dce80_opp_create( static struct output_pixel_processor *dce80_opp_create(
......
...@@ -152,15 +152,12 @@ static const struct timing_generator_funcs dce80_tg_funcs = { ...@@ -152,15 +152,12 @@ static const struct timing_generator_funcs dce80_tg_funcs = {
dce80_timing_generator_enable_advanced_request, dce80_timing_generator_enable_advanced_request,
}; };
bool dce80_timing_generator_construct( void dce80_timing_generator_construct(
struct dce110_timing_generator *tg110, struct dce110_timing_generator *tg110,
struct dc_context *ctx, struct dc_context *ctx,
uint32_t instance, uint32_t instance,
const struct dce110_timing_generator_offsets *offsets) const struct dce110_timing_generator_offsets *offsets)
{ {
if (!tg110)
return false;
tg110->controller_id = CONTROLLER_ID_D0 + instance; tg110->controller_id = CONTROLLER_ID_D0 + instance;
tg110->base.inst = instance; tg110->base.inst = instance;
tg110->offsets = *offsets; tg110->offsets = *offsets;
...@@ -177,8 +174,6 @@ bool dce80_timing_generator_construct( ...@@ -177,8 +174,6 @@ bool dce80_timing_generator_construct(
tg110->min_h_blank = 56; tg110->min_h_blank = 56;
tg110->min_h_front_porch = 4; tg110->min_h_front_porch = 4;
tg110->min_h_back_porch = 4; tg110->min_h_back_porch = 4;
return true;
} }
void dce80_timing_generator_enable_advanced_request( void dce80_timing_generator_enable_advanced_request(
......
...@@ -30,7 +30,7 @@ ...@@ -30,7 +30,7 @@
#include "../include/grph_object_id.h" #include "../include/grph_object_id.h"
/* DCE8.0 implementation inherits from DCE11.0 */ /* DCE8.0 implementation inherits from DCE11.0 */
bool dce80_timing_generator_construct( void dce80_timing_generator_construct(
struct dce110_timing_generator *tg, struct dce110_timing_generator *tg,
struct dc_context *ctx, struct dc_context *ctx,
uint32_t instance, uint32_t instance,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment