Commit 9c0b54a1 authored by Doug Anderson's avatar Doug Anderson Committed by Lee Jones

mfd: cros_ec: spi: Increase cros_ec_spi deadline from 5ms to 100ms

We're adding i2c tunneling to the list of things that goes over
cros_ec.  i2c tunneling can be slooooooow, so increase our deadline to
100ms to account for that.
Signed-off-by: default avatarDoug Anderson <dianders@chromium.org>
Reviewed-by: default avatarSimon Glass <sjg@chromium.org>
Tested-by: default avatarAndrew Bresticker <abrestic@chromium.org>
Tested-by: default avatarStephen Warren <swarren@nvidia.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent c9a81d67
...@@ -39,14 +39,22 @@ ...@@ -39,14 +39,22 @@
#define EC_MSG_PREAMBLE_COUNT 32 #define EC_MSG_PREAMBLE_COUNT 32
/* /*
* We must get a response from the EC in 5ms. This is a very long * Allow for a long time for the EC to respond. We support i2c
* time, but the flash write command can take 2-3ms. The EC command * tunneling and support fairly long messages for the tunnel (249
* processing is currently not very fast (about 500us). We could * bytes long at the moment). If we're talking to a 100 kHz device
* look at speeding this up and making the flash write command a * on the other end and need to transfer ~256 bytes, then we need:
* 'slow' command, requiring a GET_STATUS wait loop, like flash * 10 us/bit * ~10 bits/byte * ~256 bytes = ~25ms
* erase. *
*/ * We'll wait 4 times that to handle clock stretching and other
#define EC_MSG_DEADLINE_MS 5 * paranoia.
*
* It's pretty unlikely that we'll really see a 249 byte tunnel in
* anything other than testing. If this was more common we might
* consider having slow commands like this require a GET_STATUS
* wait loop. The 'flash write' command would be another candidate
* for this, clocking in at 2-3ms.
*/
#define EC_MSG_DEADLINE_MS 100
/* /*
* Time between raising the SPI chip select (for the end of a * Time between raising the SPI chip select (for the end of a
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment