Commit 9c434f5e authored by James K Lewis's avatar James K Lewis Committed by Jeff Garzik

[PATCH] Spidernet: remove ETH_ZLEN check in earlier patch

In an earlier patch, code was added to pad packets that were less that
ETH_ZLEN (60) bytes using the skb_pad function.  This has caused hangs when
accessing certain NFS mounted file systems.  This patch removes the check
and solves the NFS problem.  The driver, with this patch, has been tested
extensively.  Please apply.
Signed-off-by: default avatarJames K Lewis <jklewis@us.ibm.com>
Cc: Stephen Hemminger <shemminger@osdl.org>
Cc: Jeff Garzik <jgarzik@pobox.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent 418e8f3d
...@@ -644,20 +644,12 @@ spider_net_prepare_tx_descr(struct spider_net_card *card, ...@@ -644,20 +644,12 @@ spider_net_prepare_tx_descr(struct spider_net_card *card,
struct spider_net_descr *descr; struct spider_net_descr *descr;
dma_addr_t buf; dma_addr_t buf;
unsigned long flags; unsigned long flags;
int length;
length = skb->len; buf = pci_map_single(card->pdev, skb->data, skb->len, PCI_DMA_TODEVICE);
if (length < ETH_ZLEN) {
if (skb_pad(skb, ETH_ZLEN-length))
return 0;
length = ETH_ZLEN;
}
buf = pci_map_single(card->pdev, skb->data, length, PCI_DMA_TODEVICE);
if (pci_dma_mapping_error(buf)) { if (pci_dma_mapping_error(buf)) {
if (netif_msg_tx_err(card) && net_ratelimit()) if (netif_msg_tx_err(card) && net_ratelimit())
pr_err("could not iommu-map packet (%p, %i). " pr_err("could not iommu-map packet (%p, %i). "
"Dropping packet\n", skb->data, length); "Dropping packet\n", skb->data, skb->len);
card->spider_stats.tx_iommu_map_error++; card->spider_stats.tx_iommu_map_error++;
return -ENOMEM; return -ENOMEM;
} }
...@@ -667,7 +659,7 @@ spider_net_prepare_tx_descr(struct spider_net_card *card, ...@@ -667,7 +659,7 @@ spider_net_prepare_tx_descr(struct spider_net_card *card,
card->tx_chain.head = descr->next; card->tx_chain.head = descr->next;
descr->buf_addr = buf; descr->buf_addr = buf;
descr->buf_size = length; descr->buf_size = skb->len;
descr->next_descr_addr = 0; descr->next_descr_addr = 0;
descr->skb = skb; descr->skb = skb;
descr->data_status = 0; descr->data_status = 0;
...@@ -802,8 +794,8 @@ spider_net_release_tx_chain(struct spider_net_card *card, int brutal) ...@@ -802,8 +794,8 @@ spider_net_release_tx_chain(struct spider_net_card *card, int brutal)
/* unmap the skb */ /* unmap the skb */
if (skb) { if (skb) {
int len = skb->len < ETH_ZLEN ? ETH_ZLEN : skb->len; pci_unmap_single(card->pdev, buf_addr, skb->len,
pci_unmap_single(card->pdev, buf_addr, len, PCI_DMA_TODEVICE); PCI_DMA_TODEVICE);
dev_kfree_skb(skb); dev_kfree_skb(skb);
} }
} }
......
...@@ -24,7 +24,7 @@ ...@@ -24,7 +24,7 @@
#ifndef _SPIDER_NET_H #ifndef _SPIDER_NET_H
#define _SPIDER_NET_H #define _SPIDER_NET_H
#define VERSION "1.1 A" #define VERSION "1.5 A"
#include "sungem_phy.h" #include "sungem_phy.h"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment