Commit 9d6697b6 authored by Alan Cox's avatar Alan Cox Committed by Linus Torvalds

[PATCH] Add a comment that the irq_nosync stuff needs revisiting

parent b3b3e8a6
...@@ -903,6 +903,14 @@ int ide_config_drive_speed (ide_drive_t *drive, u8 speed) ...@@ -903,6 +903,14 @@ int ide_config_drive_speed (ide_drive_t *drive, u8 speed)
* Select the drive, and issue the SETFEATURES command * Select the drive, and issue the SETFEATURES command
*/ */
disable_irq_nosync(hwif->irq); disable_irq_nosync(hwif->irq);
/*
* FIXME: we race against the running IRQ here if
* this is called from non IRQ context. If we use
* disable_irq() we hang on the error path. Work
* is needed.
*/
udelay(1); udelay(1);
SELECT_DRIVE(drive); SELECT_DRIVE(drive);
SELECT_MASK(drive, 0); SELECT_MASK(drive, 0);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment