Commit 9dbea7f7 authored by Wei Yongjun's avatar Wei Yongjun Committed by Greg Kroah-Hartman

tracing: Fix return value check in trace_benchmark_reg()

commit 8f0994bb upstream.

In case of error, the function kthread_run() returns ERR_PTR() and never
returns NULL. The NULL test in the return value check should be replaced
with IS_ERR().

Link: http://lkml.kernel.org/r/20170112135502.28556-1-weiyj.lk@gmail.com

Fixes: 81dc9f0e ("tracing: Add tracepoint benchmark tracepoint")
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8a915b3c
...@@ -175,9 +175,9 @@ int trace_benchmark_reg(void) ...@@ -175,9 +175,9 @@ int trace_benchmark_reg(void)
bm_event_thread = kthread_run(benchmark_event_kthread, bm_event_thread = kthread_run(benchmark_event_kthread,
NULL, "event_benchmark"); NULL, "event_benchmark");
if (!bm_event_thread) { if (IS_ERR(bm_event_thread)) {
pr_warning("trace benchmark failed to create kernel thread\n"); pr_warning("trace benchmark failed to create kernel thread\n");
return -ENOMEM; return PTR_ERR(bm_event_thread);
} }
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment