Commit 9e8014fc authored by Linus Walleij's avatar Linus Walleij

gpio: twl4030: Be sure to clamp return value

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

This also makes the driver start to return the error code, as the
end of the series make this work.

Cc: Roger Quadros <rogerq@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 27ca2267
...@@ -327,7 +327,7 @@ static int twl_get(struct gpio_chip *chip, unsigned offset) ...@@ -327,7 +327,7 @@ static int twl_get(struct gpio_chip *chip, unsigned offset)
else else
status = twl4030_get_gpio_datain(offset); status = twl4030_get_gpio_datain(offset);
ret = (status <= 0) ? 0 : 1; ret = (status < 0) ? status : !!status;
out: out:
mutex_unlock(&priv->mutex); mutex_unlock(&priv->mutex);
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment