Commit a016becd authored by Heiner Kallweit's avatar Heiner Kallweit Committed by David S. Miller

net: phy: start state machine in phy_start only

The state machine is a no-op before phy_start() has been called.
Therefore let's enable it in phy_start() only. In phy_start()
let's call phy_start_machine() instead of phy_trigger_machine().
phy_start_machine is an alias for phy_trigger_machine but it makes
clearer that we start the state machine here instead of just
triggering a run.
Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8f4ebaaa
...@@ -878,7 +878,7 @@ void phy_start(struct phy_device *phydev) ...@@ -878,7 +878,7 @@ void phy_start(struct phy_device *phydev)
} }
mutex_unlock(&phydev->lock); mutex_unlock(&phydev->lock);
phy_trigger_machine(phydev); phy_start_machine(phydev);
} }
EXPORT_SYMBOL(phy_start); EXPORT_SYMBOL(phy_start);
......
...@@ -951,7 +951,6 @@ int phy_connect_direct(struct net_device *dev, struct phy_device *phydev, ...@@ -951,7 +951,6 @@ int phy_connect_direct(struct net_device *dev, struct phy_device *phydev,
return rc; return rc;
phy_prepare_link(phydev, handler); phy_prepare_link(phydev, handler);
phy_start_machine(phydev);
if (phydev->irq > 0) if (phydev->irq > 0)
phy_start_interrupts(phydev); phy_start_interrupts(phydev);
......
...@@ -676,7 +676,6 @@ static int phylink_bringup_phy(struct phylink *pl, struct phy_device *phy) ...@@ -676,7 +676,6 @@ static int phylink_bringup_phy(struct phylink *pl, struct phy_device *phy)
__ETHTOOL_LINK_MODE_MASK_NBITS, pl->supported, __ETHTOOL_LINK_MODE_MASK_NBITS, pl->supported,
__ETHTOOL_LINK_MODE_MASK_NBITS, phy->advertising); __ETHTOOL_LINK_MODE_MASK_NBITS, phy->advertising);
phy_start_machine(phy);
if (phy->irq > 0) if (phy->irq > 0)
phy_start_interrupts(phy); phy_start_interrupts(phy);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment