Commit a0279bd5 authored by Jason Wessel's avatar Jason Wessel

kgdb: have ebin2mem call probe_kernel_write once

Rather than call probe_kernel_write() one byte at a time, process the
whole buffer locally and pass the entire result in one go.  This way,
architectures that need to do special handling based on the length can
do so, or we only end up calling memcpy() once.

[sonic.zhang@analog.com: Reported original problem and preliminary patch]
Signed-off-by: default avatarJason Wessel <jason.wessel@windriver.com>
Signed-off-by: default avatarSonic Zhang <sonic.zhang@analog.com>
Signed-off-by: default avatarMike Frysinger <vapier@gentoo.org>
parent 42be79e3
...@@ -391,27 +391,22 @@ int kgdb_mem2hex(char *mem, char *buf, int count) ...@@ -391,27 +391,22 @@ int kgdb_mem2hex(char *mem, char *buf, int count)
/* /*
* Copy the binary array pointed to by buf into mem. Fix $, #, and * Copy the binary array pointed to by buf into mem. Fix $, #, and
* 0x7d escaped with 0x7d. Return a pointer to the character after * 0x7d escaped with 0x7d. Return -EFAULT on failure or 0 on success.
* the last byte written. * The input buf is overwitten with the result to write to mem.
*/ */
static int kgdb_ebin2mem(char *buf, char *mem, int count) static int kgdb_ebin2mem(char *buf, char *mem, int count)
{ {
int err = 0; int size = 0;
char c; char *c = buf;
while (count-- > 0) { while (count-- > 0) {
c = *buf++; c[size] = *buf++;
if (c == 0x7d) if (c[size] == 0x7d)
c = *buf++ ^ 0x20; c[size] = *buf++ ^ 0x20;
size++;
err = probe_kernel_write(mem, &c, 1);
if (err)
break;
mem++;
} }
return err; return probe_kernel_write(mem, c, size);
} }
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment