Commit a120d9ab authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller

netxen: fix incorrect loop counter decrement

The loop counter k is currently being decremented from zero which
is incorrect. Fix this by incrementing k instead

Detected by CoverityScan, CID#401847 ("Infinite loop")

Fixes: 83f18a55 ("netxen_nic: fw dump support")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent eac2c68d
...@@ -2311,7 +2311,7 @@ netxen_md_rdqueue(struct netxen_adapter *adapter, ...@@ -2311,7 +2311,7 @@ netxen_md_rdqueue(struct netxen_adapter *adapter,
loop_cnt++) { loop_cnt++) {
NX_WR_DUMP_REG(select_addr, adapter->ahw.pci_base0, queue_id); NX_WR_DUMP_REG(select_addr, adapter->ahw.pci_base0, queue_id);
read_addr = queueEntry->read_addr; read_addr = queueEntry->read_addr;
for (k = 0; k < read_cnt; k--) { for (k = 0; k < read_cnt; k++) {
NX_RD_DUMP_REG(read_addr, adapter->ahw.pci_base0, NX_RD_DUMP_REG(read_addr, adapter->ahw.pci_base0,
&read_value); &read_value);
*data_buff++ = read_value; *data_buff++ = read_value;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment