Commit a2ab0ce0 authored by Christian Engelmayer's avatar Christian Engelmayer Committed by David Woodhouse

jffs2: leaking jffs2_summary in function jffs2_scan_medium

In case of an error returned by file_dirty() 's' is not freed as the cleanup
path is skipped.

Reported by Coverity.
Signed-off-by: default avatarChristian Engelmayer <christian.engelmayer@frequentis.com>
Signed-off-by: default avatarDavid Woodhouse <David.Woodhouse@intel.com>
parent 272023df
...@@ -196,7 +196,7 @@ int jffs2_scan_medium(struct jffs2_sb_info *c) ...@@ -196,7 +196,7 @@ int jffs2_scan_medium(struct jffs2_sb_info *c)
if (c->nextblock) { if (c->nextblock) {
ret = file_dirty(c, c->nextblock); ret = file_dirty(c, c->nextblock);
if (ret) if (ret)
return ret; goto out;
/* deleting summary information of the old nextblock */ /* deleting summary information of the old nextblock */
jffs2_sum_reset_collected(c->summary); jffs2_sum_reset_collected(c->summary);
} }
...@@ -207,7 +207,7 @@ int jffs2_scan_medium(struct jffs2_sb_info *c) ...@@ -207,7 +207,7 @@ int jffs2_scan_medium(struct jffs2_sb_info *c)
} else { } else {
ret = file_dirty(c, jeb); ret = file_dirty(c, jeb);
if (ret) if (ret)
return ret; goto out;
} }
break; break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment