Commit a38a00fd authored by Stefan Richter's avatar Stefan Richter

firewire: core: drop unused call parameters of close_transaction

All callers inserted NULL and 0 here.
Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
parent 18e9b10f
...@@ -65,8 +65,7 @@ ...@@ -65,8 +65,7 @@
#define PHY_IDENTIFIER(id) ((id) << 30) #define PHY_IDENTIFIER(id) ((id) << 30)
static int close_transaction(struct fw_transaction *transaction, static int close_transaction(struct fw_transaction *transaction,
struct fw_card *card, int rcode, struct fw_card *card, int rcode)
u32 *payload, size_t length)
{ {
struct fw_transaction *t; struct fw_transaction *t;
unsigned long flags; unsigned long flags;
...@@ -82,7 +81,7 @@ static int close_transaction(struct fw_transaction *transaction, ...@@ -82,7 +81,7 @@ static int close_transaction(struct fw_transaction *transaction,
spin_unlock_irqrestore(&card->lock, flags); spin_unlock_irqrestore(&card->lock, flags);
if (&t->link != &card->transaction_list) { if (&t->link != &card->transaction_list) {
t->callback(card, rcode, payload, length, t->callback_data); t->callback(card, rcode, NULL, 0, t->callback_data);
return 0; return 0;
} }
...@@ -110,7 +109,7 @@ int fw_cancel_transaction(struct fw_card *card, ...@@ -110,7 +109,7 @@ int fw_cancel_transaction(struct fw_card *card,
* if the transaction is still pending and remove it in that case. * if the transaction is still pending and remove it in that case.
*/ */
return close_transaction(transaction, card, RCODE_CANCELLED, NULL, 0); return close_transaction(transaction, card, RCODE_CANCELLED);
} }
EXPORT_SYMBOL(fw_cancel_transaction); EXPORT_SYMBOL(fw_cancel_transaction);
...@@ -122,7 +121,7 @@ static void transmit_complete_callback(struct fw_packet *packet, ...@@ -122,7 +121,7 @@ static void transmit_complete_callback(struct fw_packet *packet,
switch (status) { switch (status) {
case ACK_COMPLETE: case ACK_COMPLETE:
close_transaction(t, card, RCODE_COMPLETE, NULL, 0); close_transaction(t, card, RCODE_COMPLETE);
break; break;
case ACK_PENDING: case ACK_PENDING:
t->timestamp = packet->timestamp; t->timestamp = packet->timestamp;
...@@ -130,20 +129,20 @@ static void transmit_complete_callback(struct fw_packet *packet, ...@@ -130,20 +129,20 @@ static void transmit_complete_callback(struct fw_packet *packet,
case ACK_BUSY_X: case ACK_BUSY_X:
case ACK_BUSY_A: case ACK_BUSY_A:
case ACK_BUSY_B: case ACK_BUSY_B:
close_transaction(t, card, RCODE_BUSY, NULL, 0); close_transaction(t, card, RCODE_BUSY);
break; break;
case ACK_DATA_ERROR: case ACK_DATA_ERROR:
close_transaction(t, card, RCODE_DATA_ERROR, NULL, 0); close_transaction(t, card, RCODE_DATA_ERROR);
break; break;
case ACK_TYPE_ERROR: case ACK_TYPE_ERROR:
close_transaction(t, card, RCODE_TYPE_ERROR, NULL, 0); close_transaction(t, card, RCODE_TYPE_ERROR);
break; break;
default: default:
/* /*
* In this case the ack is really a juju specific * In this case the ack is really a juju specific
* rcode, so just forward that to the callback. * rcode, so just forward that to the callback.
*/ */
close_transaction(t, card, status, NULL, 0); close_transaction(t, card, status);
break; break;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment