Commit a39cddc9 authored by Ulf Hansson's avatar Ulf Hansson Committed by Vinod Koul

dmaengine: pl330: Drop boilerplate code for suspend/resume

Let's drop the boilerplate code in the system suspend/resume callbacks and
convert to use pm_runtime_force_suspend|resume(). This change also has a
nice side effect, as pm_runtime_force_resume() may decide to leave the
device in low power state, when that is feasible, thus avoiding to waste
both time and energy during system resume.
Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
Tested-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Link: https://lore.kernel.org/r/20191205143746.24873-2-ulf.hansson@linaro.orgSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent c64738d6
...@@ -2961,12 +2961,7 @@ static int __maybe_unused pl330_suspend(struct device *dev) ...@@ -2961,12 +2961,7 @@ static int __maybe_unused pl330_suspend(struct device *dev)
{ {
struct amba_device *pcdev = to_amba_device(dev); struct amba_device *pcdev = to_amba_device(dev);
pm_runtime_disable(dev); pm_runtime_force_suspend(dev);
if (!pm_runtime_status_suspended(dev)) {
/* amba did not disable the clock */
amba_pclk_disable(pcdev);
}
amba_pclk_unprepare(pcdev); amba_pclk_unprepare(pcdev);
return 0; return 0;
...@@ -2981,10 +2976,7 @@ static int __maybe_unused pl330_resume(struct device *dev) ...@@ -2981,10 +2976,7 @@ static int __maybe_unused pl330_resume(struct device *dev)
if (ret) if (ret)
return ret; return ret;
if (!pm_runtime_status_suspended(dev)) pm_runtime_force_resume(dev);
ret = amba_pclk_enable(pcdev);
pm_runtime_enable(dev);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment