Commit a436d20d authored by David S. Miller's avatar David S. Miller

Merge branch 'cls_u32-hwoffload-fixes'

Jakub Kicinski says:

====================
incremental cls_u32 hardware offload fixes

These are incremental changes from v1 of cls_u32 fixes.
First patch is reposted in its entirety, patch 2 is an
incremental change from patch 2 of the original series.
====================
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parents 3497ed8c 201c44bd
...@@ -508,27 +508,28 @@ static int u32_replace_hw_knode(struct tcf_proto *tp, ...@@ -508,27 +508,28 @@ static int u32_replace_hw_knode(struct tcf_proto *tp,
offload.type = TC_SETUP_CLSU32; offload.type = TC_SETUP_CLSU32;
offload.cls_u32 = &u32_offload; offload.cls_u32 = &u32_offload;
if (tc_should_offload(dev, tp, flags)) { if (!tc_should_offload(dev, tp, flags))
offload.cls_u32->command = TC_CLSU32_REPLACE_KNODE; return tc_skip_sw(flags) ? -EINVAL : 0;
offload.cls_u32->knode.handle = n->handle;
offload.cls_u32->knode.fshift = n->fshift; offload.cls_u32->command = TC_CLSU32_REPLACE_KNODE;
offload.cls_u32->knode.handle = n->handle;
offload.cls_u32->knode.fshift = n->fshift;
#ifdef CONFIG_CLS_U32_MARK #ifdef CONFIG_CLS_U32_MARK
offload.cls_u32->knode.val = n->val; offload.cls_u32->knode.val = n->val;
offload.cls_u32->knode.mask = n->mask; offload.cls_u32->knode.mask = n->mask;
#else #else
offload.cls_u32->knode.val = 0; offload.cls_u32->knode.val = 0;
offload.cls_u32->knode.mask = 0; offload.cls_u32->knode.mask = 0;
#endif #endif
offload.cls_u32->knode.sel = &n->sel; offload.cls_u32->knode.sel = &n->sel;
offload.cls_u32->knode.exts = &n->exts; offload.cls_u32->knode.exts = &n->exts;
if (n->ht_down) if (n->ht_down)
offload.cls_u32->knode.link_handle = n->ht_down->handle; offload.cls_u32->knode.link_handle = n->ht_down->handle;
err = dev->netdev_ops->ndo_setup_tc(dev, tp->q->handle, err = dev->netdev_ops->ndo_setup_tc(dev, tp->q->handle,
tp->protocol, &offload); tp->protocol, &offload);
if (tc_skip_sw(flags)) if (tc_skip_sw(flags))
return err; return err;
}
return 0; return 0;
} }
...@@ -922,11 +923,17 @@ static int u32_change(struct net *net, struct sk_buff *in_skb, ...@@ -922,11 +923,17 @@ static int u32_change(struct net *net, struct sk_buff *in_skb,
ht->divisor = divisor; ht->divisor = divisor;
ht->handle = handle; ht->handle = handle;
ht->prio = tp->prio; ht->prio = tp->prio;
err = u32_replace_hw_hnode(tp, ht, flags);
if (err) {
kfree(ht);
return err;
}
RCU_INIT_POINTER(ht->next, tp_c->hlist); RCU_INIT_POINTER(ht->next, tp_c->hlist);
rcu_assign_pointer(tp_c->hlist, ht); rcu_assign_pointer(tp_c->hlist, ht);
*arg = (unsigned long)ht; *arg = (unsigned long)ht;
u32_replace_hw_hnode(tp, ht, flags);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment