Commit a48ee3e6 authored by Shawn Lin's avatar Shawn Lin Committed by Ulf Hansson

mmc: debugfs: remove BUG_ON from mmc_ext_csd_open

Return error value for file_operations callback instead
of triggering BUG_ON which is meaningless. Personally I
don't believe n != EXT_CSD_STR_LEN could happen. Anyway,
propagate the error to the caller.
Signed-off-by: default avatarShawn Lin <shawn.lin@rock-chips.com>
Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 5df0e823
...@@ -321,7 +321,11 @@ static int mmc_ext_csd_open(struct inode *inode, struct file *filp) ...@@ -321,7 +321,11 @@ static int mmc_ext_csd_open(struct inode *inode, struct file *filp)
for (i = 0; i < 512; i++) for (i = 0; i < 512; i++)
n += sprintf(buf + n, "%02x", ext_csd[i]); n += sprintf(buf + n, "%02x", ext_csd[i]);
n += sprintf(buf + n, "\n"); n += sprintf(buf + n, "\n");
BUG_ON(n != EXT_CSD_STR_LEN);
if (n != EXT_CSD_STR_LEN) {
err = -EINVAL;
goto out_free;
}
filp->private_data = buf; filp->private_data = buf;
kfree(ext_csd); kfree(ext_csd);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment