Commit a5846e21 authored by Ramkumar Ramachandra's avatar Ramkumar Ramachandra Committed by Arnaldo Carvalho de Melo

perf diff: Color the Weighted Diff column

In

  $ perf diff -c wdiff:M,N

color the numbers in the Weighted Diff column using color_snprintf(),
picking the colors using get_percent_color().
Signed-off-by: default avatarRamkumar Ramachandra <artagnon@gmail.com>
Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: http://lkml.kernel.org/r/1388390555-10808-1-git-send-email-artagnon@gmail.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 1f513b2c
...@@ -778,6 +778,7 @@ static int __hpp__color_compare(struct perf_hpp_fmt *fmt, ...@@ -778,6 +778,7 @@ static int __hpp__color_compare(struct perf_hpp_fmt *fmt,
container_of(fmt, struct diff_hpp_fmt, fmt); container_of(fmt, struct diff_hpp_fmt, fmt);
struct hist_entry *pair = get_pair_fmt(he, dfmt); struct hist_entry *pair = get_pair_fmt(he, dfmt);
double diff; double diff;
s64 wdiff;
char pfmt[20] = " "; char pfmt[20] = " ";
if (!pair) if (!pair)
...@@ -806,6 +807,18 @@ static int __hpp__color_compare(struct perf_hpp_fmt *fmt, ...@@ -806,6 +807,18 @@ static int __hpp__color_compare(struct perf_hpp_fmt *fmt,
scnprintf(pfmt, 20, "%%%d.6f", dfmt->header_width); scnprintf(pfmt, 20, "%%%d.6f", dfmt->header_width);
return value_color_snprintf(hpp->buf, hpp->size, return value_color_snprintf(hpp->buf, hpp->size,
pfmt, diff); pfmt, diff);
case COMPUTE_WEIGHTED_DIFF:
if (he->dummy)
goto dummy_print;
if (pair->diff.computed)
wdiff = pair->diff.wdiff;
else
wdiff = compute_wdiff(he, pair);
scnprintf(pfmt, 20, "%%14ld", dfmt->header_width);
return color_snprintf(hpp->buf, hpp->size,
get_percent_color(wdiff),
pfmt, wdiff);
default: default:
BUG_ON(1); BUG_ON(1);
} }
...@@ -826,6 +839,12 @@ static int hpp__color_ratio(struct perf_hpp_fmt *fmt, ...@@ -826,6 +839,12 @@ static int hpp__color_ratio(struct perf_hpp_fmt *fmt,
return __hpp__color_compare(fmt, hpp, he, COMPUTE_RATIO); return __hpp__color_compare(fmt, hpp, he, COMPUTE_RATIO);
} }
static int hpp__color_wdiff(struct perf_hpp_fmt *fmt,
struct perf_hpp *hpp, struct hist_entry *he)
{
return __hpp__color_compare(fmt, hpp, he, COMPUTE_WEIGHTED_DIFF);
}
static void static void
hpp__entry_unpair(struct hist_entry *he, int idx, char *buf, size_t size) hpp__entry_unpair(struct hist_entry *he, int idx, char *buf, size_t size)
{ {
...@@ -1007,6 +1026,9 @@ static void data__hpp_register(struct data__file *d, int idx) ...@@ -1007,6 +1026,9 @@ static void data__hpp_register(struct data__file *d, int idx)
case PERF_HPP_DIFF__RATIO: case PERF_HPP_DIFF__RATIO:
fmt->color = hpp__color_ratio; fmt->color = hpp__color_ratio;
break; break;
case PERF_HPP_DIFF__WEIGHTED_DIFF:
fmt->color = hpp__color_wdiff;
break;
default: default:
break; break;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment