Commit a67911d3 authored by Markus Elfring's avatar Markus Elfring Committed by Lee Jones

mfd: twl-core: Return directly after a failed platform_device_alloc() in add_numbered_child()

The platform_device_put() function was called in one case by the
add_numbered_child() function during error handling even if the passed
variable "pdev" contained a null pointer.
Return directly in this case.

This issue was detected by using the Coccinelle software.
Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent d347792c
...@@ -622,11 +622,8 @@ add_numbered_child(unsigned mod_no, const char *name, int num, ...@@ -622,11 +622,8 @@ add_numbered_child(unsigned mod_no, const char *name, int num,
twl = &twl_priv->twl_modules[sid]; twl = &twl_priv->twl_modules[sid];
pdev = platform_device_alloc(name, num); pdev = platform_device_alloc(name, num);
if (!pdev) { if (!pdev)
dev_dbg(&twl->client->dev, "can't alloc dev\n"); return ERR_PTR(-ENOMEM);
status = -ENOMEM;
goto err;
}
pdev->dev.parent = &twl->client->dev; pdev->dev.parent = &twl->client->dev;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment