Commit a8d6aa08 authored by Axel Lin's avatar Axel Lin Committed by Samuel Ortiz

mfd: Fix off-by-one value range checking for tps6507x

If bytes == (TPS6507X_MAX_REGISTER + 1), we have a buffer overflow when
doing memcpy(&msg[1], src, bytes).
Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
parent 7745cc8c
...@@ -68,7 +68,7 @@ static int tps6507x_i2c_write_device(struct tps6507x_dev *tps6507x, char reg, ...@@ -68,7 +68,7 @@ static int tps6507x_i2c_write_device(struct tps6507x_dev *tps6507x, char reg,
u8 msg[TPS6507X_MAX_REGISTER + 1]; u8 msg[TPS6507X_MAX_REGISTER + 1];
int ret; int ret;
if (bytes > (TPS6507X_MAX_REGISTER + 1)) if (bytes > TPS6507X_MAX_REGISTER)
return -EINVAL; return -EINVAL;
msg[0] = reg; msg[0] = reg;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment