Commit a97f52b0 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Mauro Carvalho Chehab

media: staging: media: imx: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Steve Longerbeam <slongerbeam@gmail.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: devel@driverdev.osuosl.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: default avatarRui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent d251c653
...@@ -1017,33 +1017,14 @@ static int mipi_csis_dump_regs_show(struct seq_file *m, void *private) ...@@ -1017,33 +1017,14 @@ static int mipi_csis_dump_regs_show(struct seq_file *m, void *private)
} }
DEFINE_SHOW_ATTRIBUTE(mipi_csis_dump_regs); DEFINE_SHOW_ATTRIBUTE(mipi_csis_dump_regs);
static int mipi_csis_debugfs_init(struct csi_state *state) static void mipi_csis_debugfs_init(struct csi_state *state)
{ {
struct dentry *d;
if (!debugfs_initialized())
return -ENODEV;
state->debugfs_root = debugfs_create_dir(dev_name(state->dev), NULL); state->debugfs_root = debugfs_create_dir(dev_name(state->dev), NULL);
if (!state->debugfs_root)
return -ENOMEM;
d = debugfs_create_bool("debug_enable", 0600, state->debugfs_root,
&state->debug);
if (!d)
goto remove_debugfs;
d = debugfs_create_file("dump_regs", 0600, state->debugfs_root,
state, &mipi_csis_dump_regs_fops);
if (!d)
goto remove_debugfs;
return 0;
remove_debugfs:
debugfs_remove_recursive(state->debugfs_root);
return -ENOMEM; debugfs_create_bool("debug_enable", 0600, state->debugfs_root,
&state->debug);
debugfs_create_file("dump_regs", 0600, state->debugfs_root, state,
&mipi_csis_dump_regs_fops);
} }
static void mipi_csis_debugfs_exit(struct csi_state *state) static void mipi_csis_debugfs_exit(struct csi_state *state)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment