Commit a99d1796 authored by Chuanxiao Dong's avatar Chuanxiao Dong Committed by David Woodhouse

mtd: denali.c: fix reserved all check-patch errors

Signed-off-by: default avatarChuanxiao Dong <chuanxiao.dong@intel.com>
Signed-off-by: default avatarDavid Woodhouse <David.Woodhouse@intel.com>
parent bdca6dae
...@@ -119,7 +119,7 @@ static const uint32_t reset_complete[4] = {INTR_STATUS0__RST_COMP, ...@@ -119,7 +119,7 @@ static const uint32_t reset_complete[4] = {INTR_STATUS0__RST_COMP,
INTR_STATUS3__RST_COMP}; INTR_STATUS3__RST_COMP};
/* specifies the debug level of the driver */ /* specifies the debug level of the driver */
static int nand_debug_level = 0; static int nand_debug_level;
/* forward declarations */ /* forward declarations */
static void clear_interrupts(struct denali_nand_info *denali); static void clear_interrupts(struct denali_nand_info *denali);
...@@ -991,7 +991,7 @@ static void denali_irq_enable(struct denali_nand_info *denali, ...@@ -991,7 +991,7 @@ static void denali_irq_enable(struct denali_nand_info *denali,
*/ */
static inline uint32_t denali_irq_detected(struct denali_nand_info *denali) static inline uint32_t denali_irq_detected(struct denali_nand_info *denali)
{ {
return (read_interrupt_status(denali) & DENALI_IRQ_ALL); return read_interrupt_status(denali) & DENALI_IRQ_ALL;
} }
/* Interrupts are cleared by writing a 1 to the appropriate status bit */ /* Interrupts are cleared by writing a 1 to the appropriate status bit */
...@@ -1172,9 +1172,12 @@ static int denali_send_pipeline_cmd(struct denali_nand_info *denali, ...@@ -1172,9 +1172,12 @@ static int denali_send_pipeline_cmd(struct denali_nand_info *denali,
uint32_t addr = 0x0, cmd = 0x0, page_count = 1, irq_status = 0, uint32_t addr = 0x0, cmd = 0x0, page_count = 1, irq_status = 0,
irq_mask = 0; irq_mask = 0;
if (op == DENALI_READ) irq_mask = INTR_STATUS0__LOAD_COMP; if (op == DENALI_READ)
else if (op == DENALI_WRITE) irq_mask = 0; irq_mask = INTR_STATUS0__LOAD_COMP;
else BUG(); else if (op == DENALI_WRITE)
irq_mask = 0;
else
BUG();
setup_ecc_for_xfer(denali, ecc_en, transfer_spare); setup_ecc_for_xfer(denali, ecc_en, transfer_spare);
...@@ -1448,7 +1451,8 @@ static void denali_enable_dma(struct denali_nand_info *denali, bool en) ...@@ -1448,7 +1451,8 @@ static void denali_enable_dma(struct denali_nand_info *denali, bool en)
{ {
uint32_t reg_val = 0x0; uint32_t reg_val = 0x0;
if (en) reg_val = DMA_ENABLE__FLAG; if (en)
reg_val = DMA_ENABLE__FLAG;
denali_write32(reg_val, denali->flash_reg + DMA_ENABLE); denali_write32(reg_val, denali->flash_reg + DMA_ENABLE);
ioread32(denali->flash_reg + DMA_ENABLE); ioread32(denali->flash_reg + DMA_ENABLE);
...@@ -1721,47 +1725,47 @@ static void denali_cmdfunc(struct mtd_info *mtd, unsigned int cmd, int col, ...@@ -1721,47 +1725,47 @@ static void denali_cmdfunc(struct mtd_info *mtd, unsigned int cmd, int col,
printk(KERN_INFO "cmdfunc: 0x%x %d %d\n", cmd, col, page); printk(KERN_INFO "cmdfunc: 0x%x %d %d\n", cmd, col, page);
#endif #endif
switch (cmd) { switch (cmd) {
case NAND_CMD_PAGEPROG: case NAND_CMD_PAGEPROG:
break; break;
case NAND_CMD_STATUS: case NAND_CMD_STATUS:
read_status(denali); read_status(denali);
break; break;
case NAND_CMD_READID: case NAND_CMD_READID:
reset_buf(denali); reset_buf(denali);
if (denali->flash_bank < denali->total_used_banks) { if (denali->flash_bank < denali->total_used_banks) {
/* write manufacturer information into nand /* write manufacturer information into nand
buffer for NAND subsystem to fetch. buffer for NAND subsystem to fetch.
*/ */
write_byte_to_buf(denali, write_byte_to_buf(denali,
denali->dev_info.wDeviceMaker); denali->dev_info.wDeviceMaker);
write_byte_to_buf(denali, write_byte_to_buf(denali,
denali->dev_info.wDeviceID); denali->dev_info.wDeviceID);
write_byte_to_buf(denali, write_byte_to_buf(denali,
denali->dev_info.bDeviceParam0); denali->dev_info.bDeviceParam0);
write_byte_to_buf(denali, write_byte_to_buf(denali,
denali->dev_info.bDeviceParam1); denali->dev_info.bDeviceParam1);
write_byte_to_buf(denali, write_byte_to_buf(denali,
denali->dev_info.bDeviceParam2); denali->dev_info.bDeviceParam2);
} else { } else {
int i; int i;
for (i = 0; i < 5; i++) for (i = 0; i < 5; i++)
write_byte_to_buf(denali, 0xff); write_byte_to_buf(denali, 0xff);
} }
break; break;
case NAND_CMD_READ0: case NAND_CMD_READ0:
case NAND_CMD_SEQIN: case NAND_CMD_SEQIN:
denali->page = page; denali->page = page;
break; break;
case NAND_CMD_RESET: case NAND_CMD_RESET:
reset_bank(denali); reset_bank(denali);
break; break;
case NAND_CMD_READOOB: case NAND_CMD_READOOB:
/* TODO: Read OOB data */ /* TODO: Read OOB data */
break; break;
default: default:
printk(KERN_ERR ": unsupported command" printk(KERN_ERR ": unsupported command"
" received 0x%x\n", cmd); " received 0x%x\n", cmd);
break; break;
} }
} }
...@@ -1807,7 +1811,7 @@ static void denali_hw_init(struct denali_nand_info *denali) ...@@ -1807,7 +1811,7 @@ static void denali_hw_init(struct denali_nand_info *denali)
} }
/* ECC layout for SLC devices. Denali spec indicates SLC fixed at 4 bytes */ /* ECC layout for SLC devices. Denali spec indicates SLC fixed at 4 bytes */
#define ECC_BYTES_SLC 4 * (2048 / ECC_SECTOR_SIZE) #define ECC_BYTES_SLC (4 * (2048 / ECC_SECTOR_SIZE))
static struct nand_ecclayout nand_oob_slc = { static struct nand_ecclayout nand_oob_slc = {
.eccbytes = 4, .eccbytes = 4,
.eccpos = { 0, 1, 2, 3 }, /* not used */ .eccpos = { 0, 1, 2, 3 }, /* not used */
...@@ -1819,7 +1823,7 @@ static struct nand_ecclayout nand_oob_slc = { ...@@ -1819,7 +1823,7 @@ static struct nand_ecclayout nand_oob_slc = {
} }
}; };
#define ECC_BYTES_MLC 14 * (2048 / ECC_SECTOR_SIZE) #define ECC_BYTES_MLC (14 * (2048 / ECC_SECTOR_SIZE))
static struct nand_ecclayout nand_oob_mlc_14bit = { static struct nand_ecclayout nand_oob_mlc_14bit = {
.eccbytes = 14, .eccbytes = 14,
.eccpos = { 0, 1, 2, 3, 5, 6, 7, 8, 9, 10, 11, 12, 13 }, /* not used */ .eccpos = { 0, 1, 2, 3, 5, 6, 7, 8, 9, 10, 11, 12, 13 }, /* not used */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment