Commit aa66974b authored by Bjorn Helgaas's avatar Bjorn Helgaas Committed by Russell King

[SERIAL] make ACPI serial module unload work

Patch from Bjorn Helgaas

This patch makes ACPI serial ports work right when the serial driver
is built as a module.  Previously, loading worked fine, but we
didn't clean up on module removal.
parent b6bb73e1
/* /*
* serial/acpi.c
* Copyright (c) 2002-2003 Matthew Wilcox for Hewlett-Packard * Copyright (c) 2002-2003 Matthew Wilcox for Hewlett-Packard
* Copyright (C) 2004 Hewlett-Packard Co
* Bjorn Helgaas <bjorn.helgaas@hp.com>
* *
* This program is free software; you can redistribute it and/or modify * This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by * it under the terms of the GNU General Public License as published by
...@@ -13,6 +14,7 @@ ...@@ -13,6 +14,7 @@
#include <linux/module.h> #include <linux/module.h>
#include <linux/tty.h> #include <linux/tty.h>
#include <linux/serial.h> #include <linux/serial.h>
#include <linux/tty.h>
#include <linux/serial_core.h> #include <linux/serial_core.h>
#include <acpi/acpi_bus.h> #include <acpi/acpi_bus.h>
...@@ -20,6 +22,11 @@ ...@@ -20,6 +22,11 @@
#include <asm/io.h> #include <asm/io.h>
#include <asm/serial.h> #include <asm/serial.h>
struct serial_private {
int line;
void *iomem_base;
};
static acpi_status acpi_serial_mmio(struct serial_struct *req, static acpi_status acpi_serial_mmio(struct serial_struct *req,
struct acpi_resource_address64 *addr) struct acpi_resource_address64 *addr)
{ {
...@@ -96,39 +103,72 @@ static acpi_status acpi_serial_resource(struct acpi_resource *res, void *data) ...@@ -96,39 +103,72 @@ static acpi_status acpi_serial_resource(struct acpi_resource *res, void *data)
static int acpi_serial_add(struct acpi_device *device) static int acpi_serial_add(struct acpi_device *device)
{ {
struct serial_private *priv;
acpi_status status; acpi_status status;
struct serial_struct serial_req; struct serial_struct serial_req;
int line; int result;
memset(&serial_req, 0, sizeof(serial_req)); memset(&serial_req, 0, sizeof(serial_req));
priv = kmalloc(sizeof(struct serial_private), GFP_KERNEL);
if (!priv) {
result = -ENOMEM;
goto fail;
}
memset(priv, 0, sizeof(*priv));
status = acpi_walk_resources(device->handle, METHOD_NAME__CRS, status = acpi_walk_resources(device->handle, METHOD_NAME__CRS,
acpi_serial_resource, &serial_req); acpi_serial_resource, &serial_req);
if (ACPI_FAILURE(status)) if (ACPI_FAILURE(status)) {
return -ENODEV; result = -ENODEV;
goto fail;
}
if (!serial_req.iomem_base && !serial_req.port) { if (serial_req.iomem_base)
priv->iomem_base = serial_req.iomem_base;
else if (!serial_req.port) {
printk(KERN_ERR "%s: no iomem or port address in %s _CRS\n", printk(KERN_ERR "%s: no iomem or port address in %s _CRS\n",
__FUNCTION__, device->pnp.bus_id); __FUNCTION__, device->pnp.bus_id);
return -ENODEV; result = -ENODEV;
goto fail;
} }
serial_req.baud_base = BASE_BAUD; serial_req.baud_base = BASE_BAUD;
serial_req.flags = UPF_SKIP_TEST | UPF_BOOT_AUTOCONF | UPF_AUTO_IRQ | serial_req.flags = UPF_SKIP_TEST | UPF_BOOT_AUTOCONF |
UPF_RESOURCES; UPF_AUTO_IRQ | UPF_RESOURCES;
line = register_serial(&serial_req); priv->line = register_serial(&serial_req);
if (line < 0) { if (priv->line < 0) {
printk(KERN_WARNING "Couldn't register serial port %s: %d\n", printk(KERN_WARNING "Couldn't register serial port %s: %d\n",
device->pnp.bus_id, line); device->pnp.bus_id, priv->line);
return -ENODEV; result = -ENODEV;
goto fail;
} }
acpi_driver_data(device) = priv;
return 0; return 0;
fail:
if (serial_req.iomem_base)
iounmap(serial_req.iomem_base);
kfree(priv);
return result;
} }
static int acpi_serial_remove(struct acpi_device *device, int type) static int acpi_serial_remove(struct acpi_device *device, int type)
{ {
struct serial_private *priv;
if (!device || !acpi_driver_data(device))
return -EINVAL;
priv = acpi_driver_data(device);
unregister_serial(priv->line);
if (priv->iomem_base)
iounmap(priv->iomem_base);
kfree(priv);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment