Commit aadc4e01 authored by Markus Elfring's avatar Markus Elfring Committed by Linus Torvalds

fat: delete an unnecessary check before brelse()

brelse() tests whether its argument is NULL and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Link: http://lkml.kernel.org/r/cfff3b81-fb5d-af26-7b5e-724266509045@web.deSigned-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Acked-by: default avatarOGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent b25bab17
...@@ -88,9 +88,7 @@ static int fat__get_entry(struct inode *dir, loff_t *pos, ...@@ -88,9 +88,7 @@ static int fat__get_entry(struct inode *dir, loff_t *pos,
int err, offset; int err, offset;
next: next:
if (*bh) brelse(*bh);
brelse(*bh);
*bh = NULL; *bh = NULL;
iblock = *pos >> sb->s_blocksize_bits; iblock = *pos >> sb->s_blocksize_bits;
err = fat_bmap(dir, iblock, &phys, &mapped_blocks, 0, false); err = fat_bmap(dir, iblock, &phys, &mapped_blocks, 0, false);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment