Commit abf9dc0d authored by Dan Carpenter's avatar Dan Carpenter Committed by Darren Hart

thinkpad_acpi: signedness bugs getting current_mode

This needs to be signed for the error handling to work.  Valid modes are
small positive integers.

Fixes: b790ceeb ('thinkpad_acpi: Add adaptive_kbd_mode sysfs attr')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-By: default avatarBastien Nocera <hadess@hadess.net>
Acked-by: default avatarHenrique de Moraes Holschuh <hmh@hmh.eng.br>
Signed-off-by: default avatarDarren Hart <dvhart@linux.intel.com>
parent b4dd04ac
......@@ -2938,7 +2938,7 @@ static ssize_t adaptive_kbd_mode_show(struct device *dev,
struct device_attribute *attr,
char *buf)
{
u32 current_mode;
int current_mode;
current_mode = adaptive_keyboard_get_mode();
if (current_mode < 0)
......@@ -3621,7 +3621,7 @@ static int adaptive_keyboard_get_next_mode(int mode)
static bool adaptive_keyboard_hotkey_notify_hotkey(unsigned int scancode)
{
u32 current_mode = 0;
int current_mode = 0;
int new_mode = 0;
int keycode;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment