Commit acaf24f0 authored by Mark Brown's avatar Mark Brown

ASoC: jack: Always update jack state even for noop changes

Now that DAPM is very cheap for most updates we've no need to avoid trying
to run it so always notify even if we don't think there are any changes.
This avoids potential issues with bootstrapping state like the pin state
or other notifiers when there's nothing in the jack.
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: default avatarLiam Girdwood <lrg@ti.com>
parent 5ef75e71
...@@ -83,11 +83,6 @@ void snd_soc_jack_report(struct snd_soc_jack *jack, int status, int mask) ...@@ -83,11 +83,6 @@ void snd_soc_jack_report(struct snd_soc_jack *jack, int status, int mask)
jack->status &= ~mask; jack->status &= ~mask;
jack->status |= status & mask; jack->status |= status & mask;
/* The DAPM sync is expensive enough to be worth skipping.
* However, empty mask means pin synchronization is desired. */
if (mask && (jack->status == oldstatus))
goto out;
trace_snd_soc_jack_notify(jack, status); trace_snd_soc_jack_notify(jack, status);
list_for_each_entry(pin, &jack->pins, list) { list_for_each_entry(pin, &jack->pins, list) {
...@@ -109,7 +104,6 @@ void snd_soc_jack_report(struct snd_soc_jack *jack, int status, int mask) ...@@ -109,7 +104,6 @@ void snd_soc_jack_report(struct snd_soc_jack *jack, int status, int mask)
snd_jack_report(jack->jack, jack->status); snd_jack_report(jack->jack, jack->status);
out:
mutex_unlock(&jack->mutex); mutex_unlock(&jack->mutex);
} }
EXPORT_SYMBOL_GPL(snd_soc_jack_report); EXPORT_SYMBOL_GPL(snd_soc_jack_report);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment