Commit ad2fa42d authored by James Bottomley's avatar James Bottomley

[SCSI] aha152x: fix init suspiciously returned 1, it should follow 0/-E convention

Reported-by: default avatarFrank de Jong <frapex@xs4all.nl>
> [1.] One line summary of the problem:
> linux-2.6.25.3, aha152x'->init suspiciously returned 1, it should
> follow 0/-E convention. The module / driver works okay. Unloading the
> module is impossible.

The driver is apparently returning 0 on failure and 1 on success.
That's a bit unfortunate.  Fix it by altering to -ENODEV and 0.

Cc: Stable Tree <stable@kernel.org>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
parent c8611f97
......@@ -3830,7 +3830,7 @@ static int __init aha152x_init(void)
iounmap(p);
}
if (!ok && setup_count == 0)
return 0;
return -ENODEV;
printk(KERN_INFO "aha152x: BIOS test: passed, ");
#else
......@@ -3909,7 +3909,7 @@ static int __init aha152x_init(void)
#endif
}
return 1;
return 0;
}
static void __exit aha152x_exit(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment